Skip to content

Commit 7e8eb34

Browse files
authored
Merge pull request #3100 from The-OpenROAD-Project-staging/pr-3077-fix
ci: remove variant from metadata file paths
2 parents e22e4fc + 41c0b1d commit 7e8eb34

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

flow/util/genReportTable.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
args = parser.parse_args()
5252

5353
goldFilename = f"metadata-{args.variant}-ok.json"
54-
runFilename = f"metadata-{args.variant}.json"
54+
runFilename = f"metadata.json"
5555

5656

5757
def readMetrics(fname, justLoad=False):

flow/util/uploadMetadata.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
args = parser.parse_args()
3232

3333

34-
def upload_data(db, datafile, platform, design, variant, args, rules):
34+
def upload_data(db, dataFile, platform, design, variant, args, rules):
3535
# Set the document data
3636
key = args.commitSHA + "-" + platform + "-" + design + "-" + variant
3737
doc_ref = db.collection("build_metrics").document(key)
@@ -166,9 +166,7 @@ def upload_data(db, datafile, platform, design, variant, args, rules):
166166
raise Exception(f"Failed to upload data for {platform} {design} {variant}.")
167167

168168

169-
def get_rules(platform, design, variant):
170-
runFilename = f"rules-{variant}.json"
171-
dataFile = os.path.join("designs", platform, design, runFilename)
169+
def get_rules(dataFile):
172170
data = {}
173171
if os.path.exists(dataFile):
174172
with open(dataFile) as f:
@@ -182,7 +180,7 @@ def get_rules(platform, design, variant):
182180
# Initialize Firestore client
183181
db = firestore.client()
184182

185-
runFilename = f"metadata-{args.variant}.json"
183+
RUN_FILENAME = "metadata.json"
186184

187185
for reportDir, dirs, files in sorted(os.walk("reports", topdown=False)):
188186
dirList = reportDir.split(os.sep)
@@ -193,14 +191,14 @@ def get_rules(platform, design, variant):
193191
platform = dirList[1]
194192
design = dirList[2]
195193
variant = dirList[3]
196-
dataFile = os.path.join(reportDir, runFilename)
194+
dataFile = os.path.join(reportDir, RUN_FILENAME)
197195
if not os.path.exists(dataFile):
198196
print(f"[WARN] No data file for {platform} {design} {variant}.")
199197
continue
200198
if platform == "sky130hd_fakestack" or platform == "src":
201199
print(f"[WARN] Skiping upload {platform} {design} {variant}.")
202200
continue
203201
print(f"[INFO] Get rules for {platform} {design} {variant}.")
204-
rules = get_rules(platform, design, variant)
202+
rules = get_rules(os.path.join("designs", platform, design, RUN_FILENAME))
205203
print(f"[INFO] Upload data for {platform} {design} {variant}.")
206204
upload_data(db, dataFile, platform, design, variant, args, rules)

0 commit comments

Comments
 (0)