Update dijkstra.cpp #2958
Closed
Update dijkstra.cpp #2958
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnaawasthi-26
requested review from
Panquesito7 and
realstealthninja
as code owners
|
please all this ---- Fixes #2958 |
|
It would be preferred if main functions only contained a call to tests and nothing else. You could add tests for these edge cases into the tests function |
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added input validation for edge cases in Dijkstra’s algorithm implementation.
Specifically, handled the following conditions:
If vertices <= 0, output a message and terminate.
If edges < 0, output a message and terminate.
If edges == 0, output that all nodes are isolated and terminate.
These changes improve the robustness of the program by preventing invalid graph input scenarios and providing informative user feedback.