Skip to content

Commit 095f6a3

Browse files
Maullerhelmutbuhler
andcommitted
[GEN][ZH] Fix drawable assignment in StealthUpdate::changeVisualDisguise()
Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
1 parent 7c1b1ac commit 095f6a3

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Generals/Code/GameEngine/Source/GameLogic/Object/Update/StealthUpdate.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,8 @@ void StealthUpdate::changeVisualDisguise()
755755

756756
const ThingTemplate *tTemplate = self->getTemplate();
757757

758-
TheThingFactory->newDrawable( tTemplate );
758+
// TheSuperHackers @bugfix helmutbuhler 13/04/2025 Draw was not being assigned, potentially leaking memory and causing invalid behaviour
759+
draw = TheThingFactory->newDrawable( tTemplate );
759760
if( draw )
760761
{
761762
TheGameLogic->bindObjectAndDrawable(self, draw);

GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StealthUpdate.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1055,7 +1055,8 @@ void StealthUpdate::changeVisualDisguise()
10551055

10561056
const ThingTemplate *tTemplate = self->getTemplate();
10571057

1058-
TheThingFactory->newDrawable( tTemplate );
1058+
// TheSuperHackers @bugfix helmutbuhler 13/04/2025 Draw was not being assigned, potentially leaking memory and causing invalid behaviour
1059+
draw = TheThingFactory->newDrawable( tTemplate );
10591060
if( draw )
10601061
{
10611062
TheGameLogic->bindObjectAndDrawable(self, draw);

0 commit comments

Comments
 (0)