Skip to content

Commit 433828b

Browse files
committed
[GEN] Backport CollisionContext normal origin refactor in aabtri_compute_contact_normal from Zero Hour (#772)
1 parent 768cbd1 commit 433828b

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

Generals/Code/Libraries/Source/WWVegas/WWMath/colmathaabtri.cpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
* *
2727
* Author:: Greg Hjelstrom *
2828
* *
29-
* $Modtime:: 5/08/01 9:52a $*
29+
* $Modtime:: 1/15/02 2:46p $*
3030
* *
31-
* $Revision:: 17 $*
31+
* $Revision:: 19 $*
3232
* *
3333
*---------------------------------------------------------------------------------------------*
3434
* Functions: *
@@ -503,10 +503,11 @@ static inline void aabtri_compute_contact_normal
503503
switch(CollisionContext.AxisId)
504504
{
505505
case INTERSECTION:
506-
set_norm = *CollisionContext.Tri->N;
506+
set_norm = CollisionContext.N;
507+
set_norm.Normalize();
507508
break;
508509
case AXIS_N:
509-
set_norm = -CollisionContext.Side * *CollisionContext.Tri->N;
510+
set_norm = -CollisionContext.Side * CollisionContext.N;
510511
set_norm.Normalize();
511512
break;
512513
case AXIS_A0:
@@ -559,7 +560,8 @@ static inline void aabtri_compute_contact_normal
559560
WWASSERT(set_norm.Length2() > 0.0f);
560561

561562
#else
562-
set_norm = *CollisionContext.Tri.N;
563+
set_norm = *CollisionContext.N;
564+
set_norm.Normalize();
563565
if (Vector3::Dot_Product(set_norm,CollisionContext.Move) > 0.0f) {
564566
set_norm = -(set_norm);
565567
}
@@ -832,8 +834,7 @@ bool CollisionMath::Collide
832834
(Vector3::Dot_Product(tmp_norm,move) < Vector3::Dot_Product(result->Normal,move)))
833835
{
834836
result->Normal = tmp_norm;
835-
#pragma message("fatal assert disabled for demo")
836-
//WWASSERT(WWMath::Fabs(result->Normal.Length() - 1.0f) < WWMATH_EPSILON);
837+
WWASSERT(WWMath::Fabs(result->Normal.Length() - 1.0f) < WWMATH_EPSILON);
837838
}
838839

839840
result->Fraction = CollisionContext.MaxFrac;

0 commit comments

Comments
 (0)