[GEN][ZH] Fix uninitialized memory access in DockUpdate::loadDockPositions()

Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>

Author: Mauller

Generals/Code/GameEngine/Source/GameLogic/Object/Update/DockUpdate/DockUpdate.cpp

@@ -501,7 +501,13 @@ void DockUpdate::loadDockPositions()
 		if( m_numberApproachPositions != DYNAMIC_APPROACH_VECTOR_FLAG )
 		{
 			// Dynamic means no bones
-			Coord3D approachBones[DEFAULT_APPROACH_VECTOR_SIZE];
+			// TheSuperHackers @fix helmutbuhler 19/04/2025
+			// approachBones was originally not initialized. It needs to be initialized because
+			// myDrawable->getPristineBonePositions only sets (m_numberApproachPositionBones) elements
+			// The following code copies (m_numberApproachPositions) into m_approachPositions (which CRC indirectly depends on).
+			// Initializing it to zero seems to work.
+
+			Coord3D approachBones[DEFAULT_APPROACH_VECTOR_SIZE] = {0};
 			m_numberApproachPositionBones = myDrawable->getPristineBonePositions( "DockWaiting", 1, approachBones, NULL, m_numberApproachPositions);
 			if( m_numberApproachPositions == m_approachPositions.size() )//safeguard: will always be true
 			{

GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/DockUpdate/DockUpdate.cpp

@@ -510,7 +510,13 @@ void DockUpdate::loadDockPositions()
 			if( m_numberApproachPositions != DYNAMIC_APPROACH_VECTOR_FLAG )
 			{
 				// Dynamic means no bones
-				Coord3D approachBones[DEFAULT_APPROACH_VECTOR_SIZE];
+				// TheSuperHackers @fix helmutbuhler 19/04/2025
+				// approachBones was originally not initialized. It needs to be initialized because
+				// myDrawable->getPristineBonePositions only sets (m_numberApproachPositionBones) elements
+				// The following code copies (m_numberApproachPositions) into m_approachPositions (which CRC indirectly depends on).
+				// Initializing it to zero seems to work.
+
+				Coord3D approachBones[DEFAULT_APPROACH_VECTOR_SIZE] = {0};
 				m_numberApproachPositionBones = myDrawable->getPristineBonePositions( "DockWaiting", 1, approachBones, NULL, m_numberApproachPositions);
 				if( m_numberApproachPositions == m_approachPositions.size() )//safeguard: will always be true
 				{