Compile RTS_PROFILE together with RTS_DEBUG to cut amount of compile targets

[xezon]

We currently do not use RTS_PROFILE for anything, but we eventually will when performance optimization efforts commence.

[aliendroid1]

We currently do not use RTS_PROFILE for anything, but we eventually will when performance optimization efforts commence.

But why use a macro that doesn't do anything right now. Also with tools like valgrind I don't see the point of it. Plus I think we should only focus on performance optimizations after we've dropped compatibility

[xezon]

Instrumentation markers need to go behind a macro.

[aliendroid1]

Instrumentation markers need to go behind a macro.

Valgrind and Visual studio's built in profiler don't need markers or any changes to source code to work.

[xezon]

yes but that is pure sampling

[aliendroid1]

yes but that is pure sampling

What does rts profile do that those tools can't?

[xezon]

Instrumentation.

[aliendroid1]

Instrumentation.

Like? What does it measure that they can't?

[xezon]

Yes the sampling profiler cannot do instrumentation. You can research this topic for more information.

[aliendroid1]

Yes the sampling profiler cannot do instrumentation. You can research this topic for more information.

Don't just throw around vaguely defined jargon. Give me a concrete example of a function in the profile library code and the specific utility it provides that valgrind and code under GeneralsMD\Code\GameEngine\Source\Common can not.

Just to be clear, I'm not asking about what some in-source profiling code can theoretically do that we could hypothetically need in the future. I'm asking specifically and only about the actual code in the GeneralsGameCode repository under Core/Libraries/Source/Profile

[xezon]

He is a brief writeup in msdn: https://learn.microsoft.com/en-us/visualstudio/profiling/understanding-performance-collection-methods-perf-profiler?view=vs-2022

[aliendroid1]

He is a brief writeup in msdn: https://learn.microsoft.com/en-us/visualstudio/profiling/understanding-performance-collection-methods-perf-profiler?view=vs-2022

Did you even try to read what I wrote? Thats not a name of a function

[aliendroid1]

He is a brief writeup in msdn: https://learn.microsoft.com/en-us/visualstudio/profiling/understanding-performance-collection-methods-perf-profiler?view=vs-2022

It doesn't seem like you even read the stuff in the link you shared because if you did then you'd have seen this part

Tools in the Performance Profiler that use instrumentation include the Instrumentation tools

I advise you research this topic for more information by reading the content at the link