The game crashes when a GLA players surprise attack tunnel gets subdued while deploying and the player surrenders while it is still subdued

[Mauller]

UPDATE: The tunnel network that is being subdued is still in it's deployment state, this is where the issue occurs. While it is still being subdued and the player surrenders is when the crash occurs. Fully deployed surprise tunnels do not crash the game while being subdued and the player surrenders.

So in this replay, around 32 minutes in, Rik's sneak attack tunnel in the top right of the map is being subdued by microwave tanks to disable the tunnel network.

When Rik surrenders, during player cleanup, the reallocating of teams on the tunnel network triggers the tunnel network to attempt to subdue the occupants again due to the microwave tanks. This results in a crash due to there being no associated tunnel container.

A windbg image showing the call stack

I have not yet reproduced the crash as i think it will require muliti client being enabled so one player can perform a surrender.
I can't get the crash to trigger when running a local game at least with the ways i attempted to trigger it.

One way i did manage to let the replay finish was to check the size of the container within ActiveBody::attemptDamage before the call to ActiveBody::onSubdualChange

The replay

Legi Crash 01 Defcon 6 FFA - Air Force General.zip

[Mauller]

So with some tracking down the way to cause this appears to be the following

Play a game in which there are more than one player, this is so that player::killplayer gets called. (it doesn't when playing skirmish on your own)

Deploy sneak attack tunnel and have it immediately subdued by microwave or ECM tanks.

The GLA player has to surrender, the game will then crash at this point.

Need to reproduce this under debug to properly capture the state of the game.

[Mauller]

So it seems that while the tunnel is in it's deploying state, it does not have the players tunnel system associated with it.

The issue seems to be where the damaged variant of the tunnel is being created and unblockable damage is being applied to the tunnels contained contents.

The issue here is that no valid tunnel system exists on the new surprise attack tunnel at this point so the game crashes.