China Nuke Cannon becomes stuck in GLA Tunnel Network when it enters while being deployed and firing

[WWB2-account]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

Nuke Cannons (I have only tested China vanilla nuke cannons) will become stuck in Tunnels and unable to leave under certain niche conditions; neither using the Evacuate button or the individual Exit button will let them exit.

Reproduction Steps

I have recordings of the bug but they are too big to upload here, so here is a link to the recordings in the community outpost discord: https://discord.com/channels/951133504605917224/1345211608229609523/1394054030271057981

1. Enter a Nuke Cannon in a Tunnel Network
2. Exit the Nuke Cannon, but quickly deploy the vehicle. It must still be in the entrance of the Tunnel.
3. Fire (or force fire) anywhere in range of the Nuke Cannon
4. Very quickly after firing (within ~0.5 sec or faster) order Nuke Cannon to enter Tunnel again
5. It is now stuck in the Tunnel. Only selling all your Tunnels will give you back your stuck units

Additional Context

The key to this bug is step 4. I have tried to reproduce this bug without firing, but it always emerges from the Tunnel without problem if it has not fired.
There are some interesting details to this situation:

• If the nuke cannon is deployed, enters a tunnel while deployed, then is ordered to exit, there will be a delay before it exits. This is because it "packs up" while in the tunnel before exiting. If you listen well you can even hear the packing up sounds from the tunnel.
• I have been unable to reproduce this bug in vanilla Generals, though that doesn't guarantee it doesn't exist there. After some digging I learnt that the deploy code for ZH was rewritten extensively, so it might be a point to start looking at the differences

[Caball009]

Just preventing deployed units from entering tunnels or any other container is pretty straightforward. I think it's more user-friendly to start undeploying instead, though.

For the former we could check for obj->testStatus( OBJECT_STATUS_DEPLOYED ) in ActionManager::canEnterObject.