[GEN][ZH] Make Debug MessageBoxWrapper show message box before game window creation #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this problematic with headless mode? |
Caball009
commented
Jun 3, 2025
xezon
reviewed
Jun 6, 2025
|
The opening text says "For the initialization of static / global variables, it may be preferable to get a clear alert in the form of the message box instead of a quiet log entry." But isn't this what this change touches? Why is describes as may be preferable if it is actually changed? |
xezon
reviewed
Jun 13, 2025
| @@ -422,8 +419,10 @@ void DebugLog(const char *format, ...) | |||
| ScopedCriticalSection scopedCriticalSection(TheDebugLogCriticalSection); | |||
| #endif | |||
|
|
|||
| #ifdef DEBUG_LOGGING | |||
There was a problem hiding this comment.
This #ifdef looks redundant. The whole function already is in the same #ifdef condition.
xezon
added
Minor
|
I think this change can be finalized. |
|
Needs rebasing with main and updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
DEBUG_ASSERTCRASHmay go unnoticed prior to the creation of any game window. There's no message box if the game window isn't created yet. For the initialization of static / global variables, it may be preferable to get a clear alert in the form of the message box instead of a quiet log entry.