[GEN][ZH] Fix static initialization order for StatDumpClass and LogClass

[Caball009]

Static / global variable:

GeneralsGameCode/GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp

Line 353 in 08b06e3

StatDumpClass TheStatDump("StatisticsDump.txt");

GeneralsGameCode/GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp

Lines 152 to 169 in 08b06e3

	StatDumpClass::StatDumpClass( const char *fname )
	{
	char buffer[ _MAX_PATH ];
	GetModuleFileName( NULL, buffer, sizeof( buffer ) );
	char *pEnd = buffer + strlen( buffer );
	while( pEnd != buffer )
	{
	if( *pEnd == '\\' )
	{
	*pEnd = 0;
	break;
	}
	pEnd--;
	}
	AsciiString fullPath;
	fullPath.format( "%s\\%s", buffer, fname );
	m_fp = fopen( fullPath.str(), "wt" );
	}

I ran into an issue where the initialization of global TheStatDump happened before the initialization of global TheDynamicMemoryAllocator which is used for AsciiString (aka static initialization order fiasco). This PR fixes a couple of places where that may happen, though I only noticed it for TheStatDump.

I've also added a couple of DEBUG_ASSERTCRASH. They'll work better with #1000 accepted, which was created exactly for assertions like these.

EDIT: I can't seem to find how the issue surfaced for me naturally, but it's possible to force the issue to occur.

TheDynamicMemoryAllocator is part of the game engine and TheStatDump is part of the game engine device. You can force the issue to occur when you modify the dependency list of z_generals:
Go to Properties - Configuration Properties - Linker - Input - Additional Dependencies and reverse the order of:
..\GameEngineDevice\RelWithDebInfo\z_gameenginedevice.lib
..\GameEngine\RelWithDebInfo\z_gameengine.lib

[Caball009]

It's not entirely clear to me how severe a bug needs to be to warrant a "TheSuperHackers" comment. I can change it if it's not necessary for this change.

[xezon]

On Windows it would be possible to use TLS static initialization in XLB segment to be the first to initialize.

https://stackoverflow.com/questions/14538159/tls-callback-in-windows