[ZH] Fix the bugged Heat Haze (Smudge) effect of the USA Microwave Tank #1073
Conversation
xezon
added
Bug
| } | ||
| flushSmudges: | ||
| ++smudgesBatchCount; | ||
| DX8Wrapper::Set_Vertex_Buffer(vb_access); |
There was a problem hiding this comment.
I moved this call outside the above scope, because that was within the lock of the vertex buffer, which did not appear to cause issues but is technically not right.
| @@ -467,12 +470,12 @@ void W3DSmudgeManager::render(RenderInfoClass &rinfo) | |||
| VertexMaterialClass *vmat=VertexMaterialClass::Get_Preset(VertexMaterialClass::PRELIT_DIFFUSE); | |||
| DX8Wrapper::Set_Material(vmat); | |||
| REF_PTR_RELEASE(vmat); | |||
| DX8Wrapper::Apply_Render_State_Changes(); | |||
There was a problem hiding this comment.
I removed this call, because DX8Wrapper::Draw_Triangles will call this as well and therefore it is redundant.
|
Pekaman tried this last night and it appears to mostly work for him. Before he would get a black screen. I will get more people to test it as i integrated it into a test build. |
|
IT seems rather hit and miss, some people don't blackscreen anymore, some see the full effect or a broken version of it, while others still either blackscreen or crash. Will try to grab some system specs and what affect they had with and without. |
|
Can we can get the crash dump? |
I will get them to try it again later and grab the dumps off them. It is likely graphics driver related as the crash is clean with no error message from the game. |
|
Ah. GPU crash? Ufffff. It would be useful to know if Microwave Tank was broken or ok in original game for those that have issues with this change. |
This change fixes the bugged Heat Haze (aka Smudge) effect of the USA Microwave Tank as far as I can reproduce it on my machine.
I have an AMD RX 590. I am unable to reproduce the black screen portion of the issue, but I can reliably reproduce the missing effect.
After a lot of testing and trying different code changes, I figured that this only happens when there is just a single draw call for the smudges. As soon as there were 2, everything worked perfectly. I agreed with Chat Gippity that perhaps this is some GPU driver issue that does not commit to a single draw call and needs some help to commit to it by issuing another dummy draw call.
In my tests, this avoided the issue.
We can only hope that it also fixes the black screen, unless we find a person that can reliably reproduce the black screen.
Original
generalszh.2025-06-15.18-22-00-54.mp4
This change
generalszh.2025-06-15.18-17-58-89.mp4