Skip to content

[GITHUB] Disable VCPKG builds and remove INTERNAL builds to speed up CI #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

Mauller
Copy link

@Mauller Mauller commented Jun 19, 2025

This PR updates the continuous integration pipeline to remove VCPKG builds for now and restore the regular VS22 builds for generals.

The VCPKG build options have been added that were missing for zero hour. But i have currently commented them out for future use once other issues with the build pipeline and VCPKG are resolved.

The internal builds were also removed as these are no longer seen as useful when we can live debug.

Each VCPKG build was taking 30 minutes per preset to build, which results in the build runners being blocked for long periods per PR.

@Mauller Mauller self-assigned this Jun 19, 2025
@Mauller Mauller added Critical Severity: Minor < Major < Critical < Blocker Build Anything related to building, compiling labels Jun 19, 2025
@Mauller Mauller changed the title [GIT] Comment out VCPKG builds for now and remove internal builds from the pipeline [CORE] Comment out VCPKG builds for now and remove internal builds from the pipeline Jun 19, 2025
@xezon xezon changed the title [CORE] Comment out VCPKG builds for now and remove internal builds from the pipeline [GITHUB] Disable VCPKG builds and remove INTERNAL builds to speed up CI Jun 19, 2025
@xezon xezon added the Performance Is a performance concern label Jun 19, 2025
@Mauller Mauller force-pushed the disable-vcpkg-builds-pipeline branch from a1a4923 to 841e86a Compare June 19, 2025 20:16
@Mauller Mauller force-pushed the disable-vcpkg-builds-pipeline branch from 841e86a to 52e7c25 Compare June 19, 2025 21:13
@helmutbuhler
Copy link

Thank you for this!
Maybe we also want to reduce the timeout in .github/workflows/build-toolchain.yml again to 20 minutes?

@aliendroid1
Copy link

could you remove the profile builds too and have a look at #1084

@xezon xezon merged commit 6026f2c into TheSuperHackers:main Jun 20, 2025
14 checks passed
@xezon xezon deleted the disable-vcpkg-builds-pipeline branch June 20, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Anything related to building, compiling Critical Severity: Minor < Major < Critical < Blocker Performance Is a performance concern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants