Skip to content

[GEN][ZH] Show the System Maps tab in World Builder without RTS_DEBUG #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

xezon
Copy link

@xezon xezon commented Jun 24, 2025

This change enables the System Maps tab in World Builder without RTS_DEBUG. This makes the GUI more consistent accross configurations.

TODO

  • Replicate in Generals

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker WorldBuilder Relates to World Builder labels Jun 24, 2025
@xezon xezon changed the title [ZH] Show the System Maps tab in World Builder without RTS_DEBUG [GEN][ZH] Show the System Maps tab in World Builder without RTS_DEBUG Jun 24, 2025
@xezon xezon added the Design Is a matter of game design label Jun 24, 2025
@ViTeXFTW
Copy link

ViTeXFTW commented Jun 30, 2025

I am not sure why. But with this PR the WorldBuilder crashes after the EULA accept. And running it in the debugger gives this error:

Exception thrown: read access violation.
**this** was nullptr.

for this function
inline UnsignedInt GameLogic::getFrame( void ) { return m_frame; }

Tried building and running WB from main, and #1190 which does not give this issue

@Caball009
Copy link

The creation of this branch probably predates #1184.

@xezon xezon force-pushed the xezon/show-system-maps-tab branch from 5efb773 to 58b8908 Compare June 30, 2025 20:40
@xezon
Copy link
Author

xezon commented Jun 30, 2025

Rebased.

Replicated in Generals without errors.

$ git diff a8c703fb6df41b257d838aa61362ddb79de7946b..b5e05ed3571b9c0fe6e1e85b3671a45bf5b7f5c6 > changes.patch

$ git apply -p2 --directory=Generals --reject --whitespace=fix changes.patch
changes.patch:68: trailing whitespace.
        WIN32_FIND_DATA                 findData;
Checking patch Generals/Code/Tools/WorldBuilder/src/OpenMap.cpp...
Checking patch Generals/Code/Tools/WorldBuilder/src/SaveMap.cpp...
Applied patch Generals/Code/Tools/WorldBuilder/src/OpenMap.cpp cleanly.
Applied patch Generals/Code/Tools/WorldBuilder/src/SaveMap.cpp cleanly.
warning: 1 line adds whitespace errors.

@ViTeXFTW
Copy link

ViTeXFTW commented Jul 1, 2025

The rebase fixed the issue I had.
When enabling the System Maps, should this then not be populated with the maps that comes with the game? Or is this a sperate change?

@xezon
Copy link
Author

xezon commented Jul 1, 2025

I suspect it cannot see (and edit) the maps inside the big file.

@ViTeXFTW
Copy link

ViTeXFTW commented Jul 1, 2025

Well the Systems Tab just allows you to have a "Maps" folder in the game directory which the WorldBuilder now is able to see, idk if this is useful, but it is something.

@Caball009
Copy link

I found it useful for a custom shellmap.

@xezon xezon force-pushed the xezon/show-system-maps-tab branch from 58b8908 to b9d04a6 Compare July 11, 2025 21:19
@xezon
Copy link
Author

xezon commented Jul 11, 2025

Rebased on Main

@xezon xezon merged commit 0a97cd0 into TheSuperHackers:main Jul 11, 2025
14 checks passed
@xezon xezon deleted the xezon/show-system-maps-tab branch July 11, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker WorldBuilder Relates to World Builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System Maps tab is not visible in non Debug World Builder [ZH] World Builder behaves differently when built with RTS_BUILD_OPTION_DEBUG enabled
3 participants