[GEN][ZH] Fix and simplify trailing CR LF in most logging related functions and macros #1232
+7,814
−7,729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Major
xezon
force-pushed
the
xezon/refactor-debuglog-newline-2
branch
from
ec50c38 to
9a94f0f
Compare
|
I'll review this, although I'm not yet sure about the best approach consider its size |
|
I mainly reviewed it by checking left-over \n and \r |
…with script (#1232)
…ED strings with script (#1232)
…ngs with script (#1232)
…ERBOSE_LOG, DOUBLE_DEBUG, PERF_LOG, CRCGEN_LOG, STATECHANGED_LOG, PING_LOG, BONEPOS_LOG strings with script (#1232)
xezon
force-pushed
the
xezon/refactor-debuglog-newline-2
branch
from
9a94f0f to
4ab3505
Compare
|
Rebased with Main. Fixed some mixups in 2 commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change fixes and simplifies the trailing Carriage Return \r and Line Feed \n in most logging related functions and macros. The trailing \n is now appended in the logging wrapper itself, and so user code no longer needs to add it. This makes it less error prone.
The only disadvantage is that it gives no finer control over calling DEBUG_LOG multiple times to write to the same log line. However, that is a rare use case. If such a log is needed in the future, we can add a new DEBUG_LOG_RAW macro or so.
Affected macros are:
Some logging in WWVegas ended with \r\n (CR LF) which has been fixed as well.
Most log lines have been fixed with a script. Some lines have been fixed and polished by hand. I have labeled the commits accordingly.