[GEN][ZH] Fix debug vTune ini parsing issue caused by #1231

[Mauller]

• Relates to: [GEN][ZH] Remove RTS_INTERNAL #1231

This PR fixes an issue introduced by the previous PR to cleanup RTS internal and profile.

The game under debug would not get any further than trying to parse the debug ini data.
Ignoring the assert would not work either and the game would instead hang.

[roossienb]

This is missing fixes for CommandLine.cpp and scriptengine.cpp

[Mauller]

This is missing fixes for CommandLine.cpp and scriptengine.cpp

This is only to prevent the crash that occurs when using debug, i think the idea is to have vTune used under profile.

[roossienb]

There are more locations where there are vtune functions, that used to be in debug and internal, and now are just in debug (and not in profile!). Example is the debug block in CommandXlat.cpp starting from line 3849 (it has e.g. vtune stuff in 4994, 5005).

Moving vtune to Profile should not have been done in the INTERNAL removal but in a seperate PR, per my comment #1231 (comment)

I hate it that I didn't stick with my original point and caved in instead.

The move to profile should be undone completely and be re-done, properly and tested, in a separate PR. A search on 'vtune' yields a lot of places in the code doing something. It would not suprise me if vtune doesn't work in profile either, nor will it after this hotpatch.

[Mauller]

There are more locations where there are vtune functions, that used to be in debug and internal, and now are just in debug (and not in profile!). Example is the debug block in CommandXlat.cpp starting from line 3849 (it has e.g. vtune stuff in 4994, 5005).

Moving vtune to Profile should not have been done in the INTERNAL removal but in a seperate PR, per my comment #1231 (comment)

I hate it that I didn't stick with my original point and caved in instead.

The move to profile should be undone completely and be re-done, properly and tested, in a separate PR. A search on 'vtune' yields a lot of places in the code doing something. It would not suprise me if vtune doesn't work in profile either, nor will it after this hotpatch.

This hot patch is simply to allow debug builds to work again due to the crashing.

But i understand your point overall.

[aliendroid1]

There are more locations where there are vtune functions, that used to be in debug and internal, and now are just in debug (and not in profile!). Example is the debug block in CommandXlat.cpp starting from line 3849 (it has e.g. vtune stuff in 4994, 5005).

Moving vtune to Profile should not have been done in the INTERNAL removal but in a seperate PR, per my comment #1231 (comment)

I hate it that I didn't stick with my original point and caved in instead.

Same. Felt pressured to click approve even though I wasn't really satisfied though I did comment in the approval that my approval is on the condition that we remove the vtune stuff later.

[xezon]

Superseeded by #1245

[aliendroid1]

This is missing fixes for CommandLine.cpp and scriptengine.cpp

This is only to prevent the crash that occurs when using debug, i think the idea is to have vTune used under profile.

No just don't use it at all😭. Remove it all. It's obsolete code (not modern vtune, our code for using the obsolete api)