Skip to content

[GEN][ZH] Reduce cost of GameMessage::getCommandTypeAsAsciiString by 70% #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+862 −865
Open

[GEN][ZH] Reduce cost of GameMessage::getCommandTypeAsAsciiString by 70% #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fd6f3f5
Renamed macro, no other change.
Caball009 Jul 10, 2025
569f420
Renamed macro, no other change.
Caball009 Jul 10, 2025
c0ee99f
Added switch statement; fixed spacing.
Caball009 Jul 10, 2025
b0b66f7
Added switch statement; fixed spacing.
Caball009 Jul 10, 2025
7528aa6
Fixed more spacing.
Caball009 Jul 10, 2025
014c071
Replaced return type with 'const char*'.
Caball009 Jul 14, 2025
a337c02
Removed unused function 'getContentsAsAsciiString'.
Caball009 Jul 14, 2025
64e6960
Updated function name.
Caball009 Jul 14, 2025
1f5362d
Updated function 'getCommandAsAsciiString'.
Caball009 Jul 14, 2025
fa220ca
Merge branch 'main' into improve_getCommandTypeAsAsciiString
Caball009 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Generals/Code/GameEngine/Include/Common/MessageStream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,8 +597,8 @@ class GameMessage : public MemoryPoolObject
Type getType( void ) const { return m_type; } ///< Return the message type
UnsignedByte getArgumentCount( void ) const { return m_argCount; } ///< Return the number of arguments for this msg

AsciiString getCommandAsAsciiString( void ); ///< returns a string representation of the command type.
static AsciiString getCommandTypeAsAsciiString(GameMessage::Type t);
const char *getCommandAsString( void ) const; ///< returns a string representation of the command type.
static const char *getCommandTypeAsString(GameMessage::Type t);

Int getPlayerIndex( void ) const { return m_playerIndex; } ///< Return the originating player

Expand Down
6 changes: 0 additions & 6 deletions Generals/Code/GameEngine/Include/GameNetwork/NetCommandMsg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ class NetCommandMsg : public MemoryPoolObject
void attach();
void detach();

// For debugging purposes
virtual AsciiString getContentsAsAsciiString(void) { return AsciiString::TheEmptyString; }

protected:
UnsignedInt m_timestamp;
UnsignedInt m_executionFrame;
Expand Down Expand Up @@ -86,9 +83,6 @@ class NetGameCommandMsg : public NetCommandMsg
void addArgument(const GameMessageArgumentDataType type, GameMessageArgumentType arg);
void setGameMessageType(GameMessage::Type type);

// For debugging purposes
virtual AsciiString getContentsAsAsciiString(void);

protected:
Int m_numArgs;
Int m_argSize;
Expand Down
Loading
Loading