Skip to content

[GEN][ZH] Fix hacking hackers packing and unpacking when ordered to hack the Internet #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mauller
Copy link

@Mauller Mauller commented Jul 14, 2025

This PR is an alternate / updated implementation of an earlier orphaned PR

This PR prevents hackers that are currently hacking from packing then unpacking again when told to hack the internet.
This often occurs when they are part of a selection of hackers which are idling or hacking and are ordered to hack the internet.

@Mauller Mauller self-assigned this Jul 14, 2025
@Mauller Mauller added Bug Something is not working right, typically is user facing Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour NoRetail This fix or change is not applicable with Retail game compatibility labels Jul 14, 2025
@Mauller Mauller added this to the Major bug fixes milestone Jul 14, 2025
@@ -126,16 +126,26 @@ void HackInternetAIUpdate::aiDoCommand(const AICommandParms* parms)
if (!isAllowedToRespondToAiCommands(parms))
return;

StateID currentState = getStateMachine()->getCurrentStateID();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make this const, but it's not super important.

Copy link

@Caball009 Caball009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right, typically is user facing Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker NoRetail This fix or change is not applicable with Retail game compatibility ZH Relates to Zero Hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

China Hackers pack and unpack unnecessarily when ordered to hack in a group
2 participants