-
Notifications
You must be signed in to change notification settings - Fork 84
[GEN][ZH] Implement file info generation for Generals executables #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a lot of duplication and only adds it to the main game binaries. I would suggest refactoring it into something that can generate a custom rc file per target that can then be linked. https://github.com/TheAssemblyArmada/Vanilla-Conquer/blob/vanilla/cmake/ProductVersion.cmake is an off the shelf cmake module someone wrote that I've tweaked a bit for Vanilla Conquer use which you could use or just take inspiration from?
Yes I planned to do a follow up change and move this to the resources target, so it can be reused in tools. Do you want it to be moved right away? |
Just makes sense to me to do it that way from the get go once you have it working? There is nothing technically wrong that I can see at a glance otherwise. |
GenPatcher installs a |
To the game install directory? |
Just a thought, you could fill the copyright field with something like "Based on code released under the GPLv3" or just "GNU Public License Version 3" instead of leaving it blank? |
Yeap. This is the reason I named the files |
+1 to this |
What about to add this repo URL to |
This change implements file info generation for Generals executables.
Originally the EXE properties contained no information. The new information is set in CMake which then generates RC files for Windows executables. The generated information is not yet ideal, but a starting point for further tweaks.
Renamed targets "generalsv" to "GeneralsV" and "generalszh" to "GeneralsZH" on Windows.
VERSION_BUILDNUM is now set to 0 instead of 601.