refactor(network): use packed structs for packet serialization

[bobtista]

Building on #1675, this PR uses the packed struct definitions for packet serialization

Changes

Serialization Refactor

• Replaced manual buffer manipulation with packed struct assignments in all FillBufferWith* functions
• Eliminated manual offset tracking - structs handle memory layout automatically
• Used NetPacketFieldTypes constants instead of magic character literals throughout

What Changed

Before (manual byte manipulation):

UnsignedShort offset = 0;
buffer[offset] = NetPacketFieldTypes::CommandType;
++offset;
buffer[offset] = cmdMsg->getNetCommandType();
offset += sizeof(UnsignedByte);
// ... 20+ lines of manual offset tracking and memcpy calls

After (clean struct assignment):

NetPacketFrameCommand* packet = (NetPacketFrameCommand*)buffer;
packet->commandType.header = NetPacketFieldTypes::CommandType;
packet->commandType.commandType = cmdMsg->getNetCommandType();
packet->frame.header = NetPacketFieldTypes::Frame;
packet->frame.frame = cmdMsg->getExecutionFrame();
// ... readable struct field assignments

TODO

• Replicate in Generals
• Consider similar refactor for deserialization code

[Mauller]

You need to make sure to memcopy your packed structs into the buffer once they are filled otherwise the messages won't be going anywhere :D

[bobtista]

You need to make sure to memcopy your packed structs into the buffer once they are filled otherwise the messages won't be going anywhere :D

Are you sure? As I read it, when we cast buffer to NetPacketAckCommand*, we aren't creating a local struct - we're directly treating the buffer memory as a packed struct. Every assignment like packet->commandType.header = 'T' is directly writing into the buffer at the correct offset, so no memcpy is needed. Is this not the case?

[Mauller]

Are you sure? As I read it, when we cast buffer to NetPacketAckCommand*, we aren't creating a local struct - we're directly treating the buffer memory as a packed struct. Every assignment like packet->commandType.header = 'T' is directly writing into the buffer at the correct offset, so no memcpy is needed. Is this not the case?

Ah yes, apologies, i missed that you cast a pointer to the buffer.