Skip to content

refactor(network): convert some if-else chains to switch statements #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(network): convert some if-else chains to switch statements #1682

wants to merge 3 commits into from
+262 −252

Conversation

@bobtista
Copy link

Functions Refactored

  • FirewallHelper::behaviorDetectionUpdate() - Converted 9 state checks to switch
  • ConnectionManager::processNetCommand() - Converted 15 command type checks to switch
  • DisconnectManager::processDisconnectCommand() - Converted 7 command type checks to switch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mauller Mauller Mauller left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobtista @Mauller