Skip to content

unify(network): Move GameNetwork and GameSpy files to Core #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

unify(network): Move GameNetwork and GameSpy files to Core #1733

wants to merge 1 commit into from

Conversation

@bobtista
Copy link

@bobtista bobtista commented Oct 23, 2025 •
edited by xezon
Loading

  • Moved 69 identical network files from Generals/GeneralsMD to Core

@bobtista bobtista mentioned this pull request Oct 23, 2025
Open
@xezon
Copy link

xezon commented Oct 23, 2025

Please make the unify a separate Pull Request.

@bobtista bobtista force-pushed the bobtista/unify-network branch from 771b9a9 to d3c288d Compare October 23, 2025 14:44
@bobtista bobtista changed the title refactor(network): Unify identical network code and replace manual size calculations with packed structs refactor(network): Unify identical network code Oct 23, 2025
@bobtista
Copy link
Author

Please make the unify a separate Pull Request.

Done. Follow up PR with refactor is #1734

xezon
xezon reviewed Oct 23, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on a change to try merge file contents in GameNetwork, which then means we can move more files here.

@bobtista bobtista force-pushed the bobtista/unify-network branch from d3c288d to bb35461 Compare October 23, 2025 19:59
@xezon xezon changed the title refactor(network): Unify identical network code unify(network): Move GameNetwork and GameSpy files to Core Oct 23, 2025
@xezon xezon added Gen Relates to Generals ZH Relates to Zero Hour Unify Unifies code between Generals and Zero Hour labels Oct 23, 2025
@xezon xezon added this to the Code foundation build up milestone Oct 23, 2025
@xezon
Copy link

xezon commented Oct 23, 2025

I am working on a change to try merge file contents in GameNetwork, which then means we can move more files here.

Done. After #1735 is merged, we can move all GameNetwork + GameSpy files except GUIUtil.cpp

@xezon xezon mentioned this pull request Oct 23, 2025
Open
@bobtista bobtista force-pushed the bobtista/unify-network branch 3 times, most recently from b8f5e32 to f416fe8 Compare October 25, 2025 01:31
@bobtista bobtista force-pushed the bobtista/unify-network branch from f416fe8 to 6ac9e87 Compare October 26, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Gen Relates to Generals Unify Unifies code between Generals and Zero Hour ZH Relates to Zero Hour

Projects

None yet

Milestone

Code foundation build up

Development

Successfully merging this pull request may close these issues.

2 participants

@bobtista @xezon