refactor(network): replace manual size calculations with packed structs #1734
+850
−21,975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobtista
force-pushed
the
bobtista/network-refactor
branch
from
771b9a9 to
f5b9a5e
Compare
Add packed struct definitions for all 25 network command message types to enable compile-time size validation and cleaner serialization code. Each struct corresponds to a NetCommandMsg subclass and defines the exact binary layout of that message type on the wire.
…classes Add virtual getPackedByteCount() method to NetCommandMsg base class and implement it in all 25 derived classes to return compile-time packet sizes. Changes to NetCommandMsg.h: - Add pure virtual getPackedByteCount() method to base class - Add NetLoadCompleteCommandMsg class - Add NetTimeOutGameStartCommandMsg class - Restore EA comment dividers and documentation comments Changes to NetCommandMsg.cpp: - Implement getPackedByteCount() for all 25 NetCommandMsg subclasses - Each returns sizeof() the corresponding packed struct This provides a polymorphic interface for getting packet sizes and eliminates the need for manual size calculations.
Refactor NetPacket.cpp to use the new getPackedByteCount() polymorphic interface instead of manual size calculations. Changes: - Replace large switch statement in GetGameCommandSize() with single call to msg->getPackedByteCount() - Simplify size calculations throughout by using getPackedByteCount() - Replace C-style casts with static_cast for type safety - Remove redundant manual size computations
Update ConnectionManager to instantiate specific NetCommandMsg subclasses directly instead of creating generic NetCommandMsg and setting the type. Changes: - Use NetLoadCompleteCommandMsg in loadProgressComplete() - Use NetTimeOutGameStartCommandMsg in sendTimeOutGameStart() - Remove manual setNetCommandType() calls (type set in constructor) Applied to both Generals and Zero Hour
bobtista
force-pushed
the
bobtista/network-refactor
branch
from
f5b9a5e to
b413c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.