bugfix(gui): Fix incorrect Replay incompatibility messages #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helmutbuhler
added
Bug
xezon
reviewed
Oct 27, 2025
|
|
||
| // TheSuperHackers @fix Don't check build time. Otherwise SH build will show warning when opening | ||
| // retail replays, even though it's compatible. | ||
| //if (header.versionTimeString != TheVersion->getUnicodeBuildTime()) |
| if (header.versionString != TheVersion->getUnicodeVersion()) | ||
| return false; | ||
|
|
||
| // TheSuperHackers @fix Don't check build time. Otherwise SH build will show warning when opening |
There was a problem hiding this comment.
"No longer checks the build time here to prevent incorrect Replay playback incompatibility messages when the Replay playback would actually be technically compatible."
xezon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you try to load a replay that was generated on the retail game, the replay will show in white, but when trying to load there will be a warning, that the replay might not play back correctly. The same happens with replays that were generated on SH, but a different build.
This PR fixes that by not comparing the build time, and thus also unifying the code for determining whether to show a replay in white.
We still need to find a solution for replays that were generated using a VS22 build (for example GO). I think we should change the Version string for those builds. But that's not in this PR.