Skip to content

Conversation

@xezon
Copy link

@xezon xezon commented Nov 26, 2025

This change removes all explicit AsciiString instantiations from C strings. It was applied with a script.

Risk should be low.

A risk from a refactor like this would be if a string pointer would be now compared.

const char* string;
if (string == AsciiString("Hello"))

to

const char* string;
if (string == "Hello")

But I reviewed all changes and there were only 2 comparisons and both of them are ok, comparing against an AsciiString.

This change does cut a lot of superfluous AsciiString allocations when no longer creating AsciiString from C string when calling into TheNameKeyGenerator->nameToKey, because that function needs no AsciiString to work.

UnicodeString needed no touching. No more occurences were found.

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Performance Is a performance concern Refactor Edits the code with insignificant behavior changes, is never user facing labels Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Severity: Minor < Major < Critical < Blocker Performance Is a performance concern Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant