refactor: Remove all explicit AsciiString instantiations from C strings #1916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes all explicit AsciiString instantiations from C strings. It was applied with a script.
Risk should be low.
A risk from a refactor like this would be if a string pointer would be now compared.
to
But I reviewed all changes and there were only 2 comparisons and both of them are ok, comparing against an
AsciiString.This change does cut a lot of superfluous
AsciiStringallocations when no longer creatingAsciiStringfrom C string when calling intoTheNameKeyGenerator->nameToKey, because that function needs noAsciiStringto work.UnicodeStringneeded no touching. No more occurences were found.