[GEN] Backport structure multi selection fix from Zero Hour #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShizCalev
commented
Mar 3, 2025
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Show resolved
Hide resolved
ShizCalev
changed the title
Generalcamo
added
Bug
xezon
changed the title
Mauller
reviewed
Jul 2, 2025
ShizCalev
commented
Jul 2, 2025
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
ShizCalev
commented
Jul 2, 2025
ShizCalev
changed the title
ShizCalev
changed the title
Mauller
approved these changes
Jul 11, 2025
| return STATE_FAILURE; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
If you can remove the extra added white space before and after this block, then this should be good to go.
Mauller
changed the title
xezon
changed the title
ShizCalev
commented
Jul 11, 2025
|
The code does not align with Zero Hour in terms of white space. I suggest use WinMerge or similar tool to copy code without discrepancies. It is easy to do mistakes when done by hand.. |
|
Still needs tweaking before this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash and merge
syncs the two codebases up by backporting the (partial) fix. the exploit can still be performed, but it's harder according to @Mauller .