[GEN][ZH] Fix hacking hackers packing and unpacking when told to hack the internet as part of a group #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Bug
Mauller
reviewed
Jul 11, 2025
| @@ -131,6 +131,16 @@ void HackInternetAIUpdate::aiDoCommand(const AICommandParms* parms) | |||
| if (!isAllowedToRespondToAiCommands(parms)) | |||
| return; | |||
|
|
|||
| // TheSuperHackers @bugfix andrew-2e128 07/03/2025 Hackers pack and unpack unnecessary when selected in a group fixed. - issue #223 | |||
There was a problem hiding this comment.
This needs wrapping in a #if !RETAIL_COMPATIBLE_CRC block
| @@ -131,6 +131,16 @@ void HackInternetAIUpdate::aiDoCommand(const AICommandParms* parms) | |||
| if (!isAllowedToRespondToAiCommands(parms)) | |||
| return; | |||
|
|
|||
| // TheSuperHackers @bugfix andrew-2e128 07/03/2025 Hackers pack and unpack unnecessary when selected in a group fixed. - issue #223 | |||
| if (parms->m_cmd == AICMD_HACK_INTERNET) | |||
There was a problem hiding this comment.
These could also be condensed into a single if statement
Mauller
added
NoRetail
Mauller
changed the title
andrew-2e128
force-pushed
the
the-super-hacker-fixes
branch
from
514b819 to
e665fd7
Compare
Mauller
reviewed
Jul 13, 2025
| @@ -126,6 +126,16 @@ void HackInternetAIUpdate::aiDoCommand(const AICommandParms* parms) | |||
| if (!isAllowedToRespondToAiCommands(parms)) | |||
| return; | |||
|
|
|||
| // TheSuperHackers @bugfix andrew-2e128 07/03/2025 Hackers pack and unpack unnecessary when selected in a group fixed. - issue #223 | |||
There was a problem hiding this comment.
The wording here also needs fixing up along the lines of
"prevent hacking hackers packing and unpacking when told to hack the internet as part of a group selection"
|
The other points still need addressing, we have taken measures to allow fixes to be merged that are not retail compatible by wrapping them in a conditional statement. This way fixes can be merged without affecting retail compatibility till we decide to break it. So the above points still need addressing like bellow #if !RETAIL_COMPATIBLE_CRC
if (parms->m_cmd == AICMD_HACK_INTERNET && ( getStateMachine()->getCurrentStateID() == HACK_INTERNET || getStateMachine()->getCurrentStateID() == UNPACKING ) )
{
return;
}
#endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for Both Generals & Generals ZH
This causes mismatch with anyone who does not have the patch.