[CORE][GEN] Sync WWAudio with Zero Hour, move w3dview files to Core and prepare w3dview target for Generals #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
force-pushed
the
xezon/generals-w3dview
branch
from
e9e8406 to
c8782b2
Compare
23 tasks
xezon
force-pushed
the
xezon/generals-w3dview
branch
2 times, most recently
from
be189fd to
de03b16
Compare
Mauller
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Looks good to me, replicates all of the prior changes as mentioned and branch builds both variants of W3DView.
Only issue is that W3Dview will crash under debug for the generals variant and not continue if you ignore the assert, it just immediately closes.
The zero hour variant will continue and load the application if the assert is ignored.
The release variants for both run fine though.
xezon
force-pushed
the
xezon/generals-w3dview
branch
from
de03b16 to
37869ec
Compare
|
Works fine after the recent push and sorting out my local VCPKG setup for use with Cmake GUI. |
tomsons26
approved these changes
Apr 27, 2025
…tables for Generals and Zero Hour (#709)
xezon
force-pushed
the
xezon/generals-w3dview
branch
from
37869ec to
82876a2
Compare
|
Removed the unnecessary comments from w3dview CMakeLists.txt |
xezon
added a commit
that referenced
this pull request
Apr 27, 2025
xezon
added a commit
that referenced
this pull request
Apr 27, 2025
xezon
added a commit
that referenced
this pull request
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change replicates the following to get WWAudio of Generals in sync with Zero Hour.
It then moves all w3dview files to Core and creates a library interface that allows both Generals and Zero Hour to build a version of it.
The Generals w3dview build is disabled, because it has left over compile errors from WW3D2.
It can be enabled by commenting out
# add_subdirectory(W3DView).