[CORE] Unify remaining WWMath #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like @tomsons26 to chime in on this. Testing is good, but deciphering the differences will be king. |
tomsons26
approved these changes
Apr 24, 2025
|
Can we get a write up on what these math changes are? |
|
I think before moving I would like to make a change where we move the remaining code to Generals, so that we have it in history and can document the changes to Generals. |
|
This move can now be finalized because WWMath code is now in sync. |
OmniBlade
force-pushed
the
wwmath-unify
branch
2 times, most recently
from
9b6d899 to
f55dfb5
Compare
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After playtests by our QA team there were no differences spotted
Testing was performed by @roossienb: