Skip to content

[CMAKE] Fix feature infos of debug options #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xezon
Copy link

@xezon xezon commented Apr 26, 2025

This change fixes incorrect feature info setup for debug options in cmake.

Affects

  • DebugLogging
  • DebugCrashing
  • DebugStacktrace
  • DebugProfile

Previously it would claim that the debug options were always turned on.

@xezon xezon added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Build Anything related to building, compiling labels Apr 26, 2025
@xezon xezon requested a review from OmniBlade April 26, 2025 19:37
@xezon xezon force-pushed the xezon/fix-cmake-debug-option-feature-info branch from ab88779 to ac257ec Compare April 28, 2025 17:09
@xezon xezon removed the Bug Something is not working right label Apr 28, 2025
@xezon xezon merged commit dc0ff50 into TheSuperHackers:main Apr 28, 2025
18 checks passed
@xezon xezon deleted the xezon/fix-cmake-debug-option-feature-info branch April 28, 2025 17:34
@xezon xezon added this to the Code foundation build up milestone Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Anything related to building, compiling Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants