Skip to content

[GEN][ZH] Fix DEBUG_CRC compile errors #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

[GEN][ZH] Fix DEBUG_CRC compile errors #778

merged 1 commit into from
Apr 29, 2025

Conversation

xezon
Copy link

@xezon xezon commented Apr 28, 2025

This change fixes compile errors from enabling DEBUG_CRC without DEBUG_LOGGING.

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Build Anything related to building, compiling labels Apr 28, 2025
@xezon xezon added this to the Code foundation build up milestone Apr 28, 2025
@xezon xezon requested a review from helmutbuhler April 28, 2025 20:37
@xezon xezon mentioned this pull request Apr 28, 2025
Closed
@xezon xezon added the Debug Is mostly debug functionality label Apr 28, 2025
helmutbuhler
helmutbuhler approved these changes Apr 28, 2025
View reviewed changes
Copy link

@helmutbuhler helmutbuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xezon xezon merged commit 7735f6f into TheSuperHackers:main Apr 29, 2025
18 checks passed
@xezon xezon deleted the xezon/fix-crcdebug-compile-error branch April 29, 2025 17:59
@xezon xezon added Gen Relates to Generals ZH Relates to Zero Hour labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helmutbuhler helmutbuhler helmutbuhler approved these changes

Assignees
No one assigned
Labels
Build Anything related to building, compiling Debug Is mostly debug functionality Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour
Projects
None yet
Milestone
Code foundation build up
Development

Successfully merging this pull request may close these issues.
2 participants
@xezon @helmutbuhler