[GITHUB] Update build-toolchain to use public VC6 from itsmattkc repo

[fbraz3]

This pull request updates the build workflow to download the VC6 toolchain from a public repository.

Key changes:

• Uses the public itsmattkc/MSVC600 repository to fetch the VC6 portable toolchain.
• Removes the need to maintain or use any secrets for toolchain downloads in CI builds.
• Simplifies maintenance and improves transparency for all contributors.

This change makes the build process more secure and easier to reproduce for everyone.

[xezon]

If itsmattkc takes the repo private, then this breaks. Are we allowed to fork this repository or is this illegal?

[fbraz3]

There are already several forks of this repository. If itsmattkc decides to make the repository private or remove it, we can simply switch to another existing fork. Alternatively, we could revert to using the AWS backup if necessary.

https://github.com/itsmattkc/MSVC600/forks?include=active%2Cinactive%2Cnetwork&page=1&period=&sort_by=stargazer_counts

But realistically, this repository has been public for almost five years, and we are talking about end-of-life software. I find it unlikely that it will be taken down at this point.

Regarding the legality of keeping a fork, I am not a lawyer, but as far as I know, simply maintaining a fork of freely distributed executables—without modifying or hacking the binaries—should not be illegal. However, if there are any concerns, we should seek legal advice to be certain.

[roossienb]

If allowed, Superhackers should make their own fork

[ViTeXFTW]

I guess allowed would be based on whatever Microsoft says no? As it is their software, don't know if you still need a license for VS6. If you don't then we could just create our own repo and not even fork this one.

[Mauller]

it would probably be better to have our own repo, that ways it's easier for people to get hold of a copy for local use as well and it keeps dependencies within the project as much as possible.

[xezon]

We can do that if someone can find out if that is ok to do.

[fbraz3]

In legal terms what’s the difference between get vs6 from an s3 bucket and get it from any public repo?

[ViTeXFTW]

What i can read me to, it looks like we would need a license and run the script locally. I believe the actions run on @tintinhamans's home server? So that should have the license?

[xezon]

@OmniBlade what are your thoughts on this?

[OmniBlade]

It does make it easier to do builds in our own forks, I'd be inclined to go with it and we either revert/fix it if the repo goes down and hope we don't need VC6 by the time that happens. Github is owned by Microsoft so while someone has directed their infrastructure to create the repo, its being served from Microsoft infrastructure to be run on Microsoft infrastructure. At worst they would just stop it if they took issue with it and its not really any different from what we are doing now? Probably legally more in the clear that having Amazons infrastructure provide copies, but still clear as mud.