Skip to content

Commit 3ef3de6

Browse files
Minor error solution
- Error when searching for license in organization accounts' repositories - Now the icon is displayed in the 'about' window
1 parent 52b7c9b commit 3ef3de6

File tree

5 files changed

+12
-7
lines changed

5 files changed

+12
-7
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@
2929
## Install via deb package
3030
To install github-webscrapping, you will first need to download the **Debian package**, which can be found at the following link:
3131

32-
<a href="https://github.com/TheWatcherMultiversal/github-webscrapping/releases/download/v1.0.4/github-webscrapping_1.0.4_all.deb" target="_blank">📦 Download deb package</a>
32+
<a href="https://github.com/TheWatcherMultiversal/github-webscrapping/releases/download/v1.0.5/github-webscrapping_1.0.5_all.deb" target="_blank">📦 Download deb package</a>
3333

3434
Once we have our **Debian package** installed, simply execute the following command, and it will be downloaded to our system:
3535

36-
sudo dpkg -i github-webscrapping_1.0.4_all.deb
36+
sudo dpkg -i github-webscrapping_1.0.5_all.deb
3737

3838
- Note: If we find any missing dependencies, it's just a matter of installing them with the `sudo apt install -f` command
3939

code/about.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ def setupUi(self, MainWindow):
2020
MainWindow.resize(491, 302)
2121
MainWindow.setMinimumSize(QtCore.QSize(491, 302))
2222
MainWindow.setMaximumSize(QtCore.QSize(491, 302))
23+
icon = QtGui.QIcon()
24+
icon.addPixmap(QtGui.QPixmap("/usr/share/github-webscrapping/icons/github-webscrapping.svg"), QtGui.QIcon.Normal, QtGui.QIcon.Off)#-----> Icon App
25+
MainWindow.setWindowIcon(icon)
2326
self.centralwidget = QtWidgets.QWidget(MainWindow)
2427
self.centralwidget.setObjectName("centralwidget")
2528
self.label = QtWidgets.QLabel(self.centralwidget)
@@ -81,7 +84,7 @@ def retranslateUi(self, MainWindow):
8184
_translate = QtCore.QCoreApplication.translate
8285
MainWindow.setWindowTitle(_translate("MainWindow", "About"))
8386
self.label.setText(_translate("MainWindow", "GitHub-WebScrapping"))
84-
self.label_3.setText(_translate("MainWindow", "Version 1.0.4"))
87+
self.label_3.setText(_translate("MainWindow", "Version 1.0.5"))
8588
self.label_2.setText(_translate("MainWindow", "GitHub web scraping helps to make queries to profiles on GitHub and visualize information about their repositories."))
8689
self.label_4.setText(_translate("MainWindow", "© Angel M 2021 - 2023"))
8790
self.label_5.setText(_translate("MainWindow", "GNU GENERAL PUBLIC LICENSE v3"))

code/github-webscrapping.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
args = parser.parse_args()
3434

3535
if args.version:
36-
print('github-webscrapping 1.0.4')
36+
print('github-webscrapping 1.0.5')
3737
sys.exit()
3838

3939

@@ -1017,7 +1017,9 @@ def click_listwidget(self):
10171017

10181018
# -> Set license
10191019
license_ = Elements.find('span', {'class': 'mr-3', 'data-view-component': 'true'})
1020-
if license_ != None:
1020+
not_license = license_.find('svg', {'class' : 'octicon octicon-law mr-1', 'data-view-component' : 'true'})
1021+
1022+
if not_license != None and license_ != None:
10211023
license_ = license_.get_text()
10221024
license_ = license_.replace("\n", "")
10231025
print(f'license = {license_}')

designer/about.ui

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
<item>
6060
<widget class="QLabel" name="label_3">
6161
<property name="text">
62-
<string>Version 1.0.4</string>
62+
<string>Version 1.0.5</string>
6363
</property>
6464
</widget>
6565
</item>

install.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
# |
2525
# °-- Defining the variable names:
2626

27-
version = '1.0.4'
27+
version = '1.0.5'
2828
package = f'github-webscrapping_{version}_all.tar.gz'
2929
url_package = f'https://github.com/TheWatcherMultiversal/github-webscrapping/releases/download/v{version}/{package}'
3030

0 commit comments

Comments
 (0)