Add ROTATE_180 constant that rotates the screen 180 degrees to allow screen to be mounted inverted #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mounting the screen inverted
|
I'm working on my own variation of the desk clock, but I ended up with a setup that has the screen pins at the top. So, I created this patch to support rotating the screen 180*. |
marcelstoer
reviewed
Jul 28, 2024
| @@ -848,6 +851,7 @@ uint8_t changeScreen(TS_Point p, uint8_t screen) { | |||
| // if (p.x <= dividerMiddle) Serial.print(" right "); // <= 120 | |||
| // Serial.println(); | |||
|
|
|||
| #ifndef ROTATE_180 | |||
There was a problem hiding this comment.
I personally don't like inverted if/else conditions. Can you start with the truthy condition (ifdef)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mounting the screen inverted
Fixes #<GitHub-issue-number>.
Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.
<Description of and rationale behind this PR>