Fix "unexpected object type in string conversion" error when using booleans (#1767)

Author: juliusgeo

tiledb/npbuffer.cc

@@ -279,6 +279,14 @@ if (PyUnicode_Check(u.ptr())) {
         }
 
         sz = a.nbytes();
+      } else if (PyBool_Check(o)) {
+        if (idx < 1)
+          first_dtype = py::dtype("bool");
+
+        auto a = py::cast<py::bool_>(o);
+        sz = sizeof(bool);
+        bool bool_value = a;
+        input_p = reinterpret_cast<const char *>(&bool_value);
       } else {
         // TODO write the type in the error here
         // auto o_h = py::reinterpret_borrow<py::object>(o);
@@ -312,6 +320,11 @@ if (PyUnicode_Check(u.ptr())) {
         auto arr = py::cast<py::array>(pyobj_p);
         sz = arr.nbytes();
         input_p = (const char *)arr.data();
+      } else if (PyBool_Check(pyobj_p)) {
+        py::bool_ bool_obj = py::cast<py::bool_>(pyobj_p);
+        sz = sizeof(bool);
+        bool bool_value = bool_obj;
+        input_p = reinterpret_cast<const char *>(&bool_value);
       } else {
         // TODO add object type
         TPY_ERROR_LOC("Unexpected object type in buffer conversion");
@@ -391,6 +404,14 @@ if (PyUnicode_Check(u.ptr())) {
       } else if (npy_api.PyArray_Check_(obj_p)) {
         // handle (potentially) var-len embedded arrays
         sz = py::cast<py::array>(obj_p).nbytes();
+      } else if (PyBool_Check(obj_p)) {
+        if (idx < 1)
+          first_dtype = py::dtype("bool");
+
+        py::bool_ bool_obj = py::cast<py::bool_>(obj_p);
+        sz = sizeof(bool);
+        bool bool_value = bool_obj;
+        input_p = reinterpret_cast<const char *>(&bool_value);
       } else {
         auto errmsg =
             std::string("Unexpected object type in string conversion");
@@ -424,6 +445,11 @@ if (PyUnicode_Check(u.ptr())) {
         auto o_a = py::cast<py::array>(obj_h);
         sz = o_a.nbytes();
         input_p = (const char *)o_a.data();
+      } else if (PyBool_Check(obj_p)) {
+        py::bool_ bool_obj = py::cast<py::bool_>(obj_p);
+        sz = sizeof(bool);
+        bool bool_value = bool_obj;
+        input_p = reinterpret_cast<const char *>(&bool_value);
       } else {
         TPY_ERROR_LOC("Unexpected object type in buffer conversion");
       }

tiledb/tests/test_query_condition.py

@@ -845,6 +845,30 @@ def test_qc_enumeration(self):
                 == list(enum2.values()).index("bb")
             )
 
+    def test_boolean_insert(self):
+        path = self.path("test_boolean_insert")
+        attr = tiledb.Attr("a", dtype=np.bool_, var=True)
+        dom = tiledb.Domain(tiledb.Dim(domain=(1, 10), tile=1, dtype=np.uint32))
+        schema = tiledb.ArraySchema(domain=dom, sparse=True, attrs=[attr])
+        tiledb.Array.create(path, schema)
+        a = np.array(
+            list(
+                [
+                    np.array([True], dtype=np.bool_),
+                    np.array([True], dtype=np.bool_),
+                    np.array([True], dtype=np.bool_),
+                    np.array([True], dtype=np.bool_),
+                ]
+            ),
+            dtype=object,
+        )
+        with tiledb.open(path, "w") as A:
+            A[range(1, len(a) + 1)] = {"a": a}
+
+        with tiledb.open(path, "r") as A:
+            for k in A[:]["a"]:
+                assert k[0] == True  # noqa: E712
+
 
 class QueryDeleteTest(DiskTestCase):
     def test_basic_sparse(self):