feat: add a producer id to BestSolutionChangedEvent #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
reviewed
Nov 4, 2025
Collaborator
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
Good idea on the event type! I think we can still improve on it.
core/src/main/java/ai/timefold/solver/core/api/solver/event/BestSolutionChangedEvent.java
Outdated
Show resolved
Hide resolved
...va/ai/timefold/solver/core/impl/constructionheuristic/DefaultConstructionHeuristicPhase.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/phase/custom/DefaultCustomPhase.java
Outdated
Show resolved
Hide resolved
core/src/test/java/ai/timefold/solver/core/impl/solver/DefaultSolverTest.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/api/solver/event/BestSolutionChangedEvent.java
Outdated
Show resolved
Hide resolved
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
reviewed
Nov 5, 2025
Collaborator
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
I'll have to ask the platform guys about serialization of the events. That will give us some context here.
core/src/main/java/ai/timefold/solver/core/api/solver/event/BestSolutionChangedEvent.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/api/solver/event/EventProducerId.java
Outdated
Show resolved
Hide resolved
...va/ai/timefold/solver/core/impl/constructionheuristic/DefaultConstructionHeuristicPhase.java
Outdated
Show resolved
Hide resolved
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
A Problem Change does not trigger a new best solution event if it occurs before Construction Heuristic finishes.
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
reviewed
Nov 6, 2025
Collaborator
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
We're missing the identification on the first initialized solution consumer. After that, we're good.
core/src/main/java/ai/timefold/solver/core/impl/phase/PhaseType.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/phase/PhaseType.java
Outdated
Show resolved
Hide resolved
…olution Having a consumer that accepts the solution was fragile, since whenever we wanted to add additional info, we would need to create an additional overload. Using events allows us to add new methods without affecting user code.
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
triceo
approved these changes
Nov 8, 2025
Collaborator
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
Only one comment. As agreed, I'll fix it myself.
core/src/main/java/ai/timefold/solver/core/api/solver/SolverJobBuilder.java
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.