updates async check, patches test

Author: TimoKoerber

src/Commands/OneTimeOperationsProcessCommand.php

@@ -127,20 +127,15 @@ protected function storeOperation(OneTimeOperationFile $operationFile): void
             return;
         }
 
-        Operation::storeOperation($operationFile->getOperationName(), $operationFile->getClassObject()->isAsync());
+        Operation::storeOperation($operationFile->getOperationName(), $this->isAsyncMode($operationFile));
     }
 
-    protected function processOperation(OneTimeOperationFile $operationInstance)
+    protected function processOperation(OneTimeOperationFile $operationFile)
     {
-        $operation = $operationInstance->getClassObject();
-
-        $this->forceAsync && $operation->setAsync();
-        $this->forceSync && $operation->setSync();
-
-        if ($operation->isAsync()) {
-            OneTimeOperationProcessJob::dispatch($operationInstance->getOperationName());
+        if ($this->isAsyncMode($operationFile)) {
+            OneTimeOperationProcessJob::dispatch($operationFile->getOperationName());
         } else {
-            OneTimeOperationProcessJob::dispatchSync($operationInstance->getOperationName());
+            OneTimeOperationProcessJob::dispatchSync($operationFile->getOperationName());
         }
     }
 
@@ -156,7 +151,7 @@ protected function displayTestmodeWarning(): void
         }
     }
 
-    protected function isAsyncMode(bool $fallback): bool
+    protected function isAsyncMode(OneTimeOperationFile $operationFile): bool
     {
         if ($this->forceAsync) {
             return true;
@@ -166,6 +161,6 @@ protected function isAsyncMode(bool $fallback): bool
             return false;
         }
 
-        return $fallback;
+        return $operationFile->getClassObject()->isAsync();
     }
 }

src/OneTimeOperation.php

@@ -14,20 +14,6 @@ abstract class OneTimeOperation
      */
     abstract public function process(): void;
 
-    public function setAsync(): self
-    {
-        $this->async = true;
-
-        return $this;
-    }
-
-    public function setSync(): self
-    {
-        $this->async = false;
-
-        return $this;
-    }
-
     public function isAsync(): bool
     {
         return $this->async;

tests/Feature/OneTimeOperationCommandTest.php

@@ -27,7 +27,7 @@ public function test_the_whole_command_process()
         // create operation file
         $this->artisan('operations:make AwesomeOperation')
             ->assertSuccessful()
-            ->expectsOutputToContain('One-time-operation [2015_10_21_072800_awesome_operation] created successfully.');
+            ->expectsOutputToContain('One-time operation [2015_10_21_072800_awesome_operation] created successfully.');
 
         // file was created, but no operation entry yet
         $this->assertFileExists($filepath);