🔧 mypy fix typing in pyramid.py
#938
Conversation
Jiaqi-Lv
changed the title
mypy fix typing in pyramid.pymypy fix typing in pyramid.py
Jiaqi-Lv
changed the title
mypy fix typing in pyramid.pypyramid.py
Jiaqi-Lv
changed the title
pyramid.pymypy fix typing in pyramid.py
| @@ -399,6 +395,19 @@ def __iter__(self: TilePyramidGenerator) -> Iterator: | |||
| for x, y in np.ndindex(self.tile_grid_size(level)): | |||
| yield self.get_tile(level=level, x=x, y=y) | |||
|
|
|||
| def _compression_mode_to_literal( | |||
There was a problem hiding this comment.
TarFile.open() requires mode to be Literal type, which means it can not be a normal str type and it can not be assigned from another variable, it has to be a literal string. I think this is the best way to do it.
There was a problem hiding this comment.
@Jiaqi-Lv I fixed this mypy issue yesterday in PR #841, in a way that I think changes less code - take a look and let me know if you think its ok, otherwise we will have some merge issues if we try to merge that PR after this one. That PR is ready for review now anyway, so shouldn't have to wait long to merge it in
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #938 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 71 71
Lines 8934 8943 +9
Branches 1171 1174 +3
========================================
+ Hits 8907 8916 +9
Misses 23 23
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixed typing issue in
pyramid.py.