Skip to content

Commit 1611644

Browse files
authored
Chore: Remove obsolete warning when converting a dbt project (#4685)
1 parent 128ffe1 commit 1611644

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

sqlmesh/dbt/model.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -314,14 +314,6 @@ def model_kind(self, context: DbtContext) -> ModelKind:
314314
**incremental_by_kind_kwargs,
315315
)
316316

317-
incremental_by_time_str = collection_to_str(INCREMENTAL_BY_TIME_STRATEGIES)
318-
incremental_by_unique_key_str = collection_to_str(
319-
INCREMENTAL_BY_UNIQUE_KEY_STRATEGIES.union(["none"])
320-
)
321-
get_console().log_warning(
322-
f"Using unmanaged incremental materialization for model '{self.canonical_name(context)}'. "
323-
f"Some features might not be available. Consider adding either a time_column ({incremental_by_time_str}) or a unique_key ({incremental_by_unique_key_str}) configuration to mitigate this.",
324-
)
325317
strategy = self.incremental_strategy or target.default_incremental_strategy(
326318
IncrementalUnmanagedKind
327319
)

tests/dbt/test_transformation.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1314,7 +1314,6 @@ def test_clickhouse_properties(mocker: MockerFixture):
13141314
"SQLMesh does not support 'incremental_predicates' - they will not be applied.",
13151315
"SQLMesh does not support the 'query_settings' model configuration parameter. Specify the query settings directly in the model query.",
13161316
"SQLMesh does not support the 'sharding_key' model configuration parameter or distributed materializations.",
1317-
"Using unmanaged incremental materialization for model '`test`.`model`'. Some features might not be available. Consider adding either a time_column ('delete+insert', 'insert_overwrite') or a unique_key ('merge', 'none') configuration to mitigate this.",
13181317
]
13191318

13201319
assert [e.sql("clickhouse") for e in model_to_sqlmesh.partitioned_by] == [

0 commit comments

Comments
 (0)