chore(vscode): lint the tests folder (#4893)

Author: benfdking

vscode/extension/package.json

@@ -117,8 +117,8 @@
   },
   "scripts": {
     "ci": "pnpm run lint && pnpm run compile && pnpm run test:unit",
-    "lint": "eslint src",
-    "lint:fix": "eslint src --fix",
+    "lint": "eslint src tests",
+    "lint:fix": "eslint src tests --fix",
     "test:unit": "vitest run",
     "code-server": "code-server",
     "test:e2e": "pnpm run vscode:package && playwright test",

vscode/extension/tests/extension.setup.ts

@@ -3,6 +3,7 @@ import { execSync } from 'child_process'
 import path from 'path'
 import fs from 'fs-extra'
 import { createHash } from 'crypto'
+import { tmpdir } from 'os'
 
 setup('prepare extension', async () => {
   console.log('Setting up extension for Playwright tests...')
@@ -32,7 +33,7 @@ setup('prepare extension', async () => {
 
   // Create a temporary user data directory for the installation
   const tempUserDataDir = await fs.mkdtemp(
-    path.join(require('os').tmpdir(), 'vscode-test-install-user-data-'),
+    path.join(tmpdir(), 'vscode-test-install-user-data-'),
   )
 
   try {

vscode/extension/tests/lineage.spec.ts

@@ -1,4 +1,4 @@
-import { test, expect, Page } from '@playwright/test'
+import { test, Page } from '@playwright/test'
 import path from 'path'
 import fs from 'fs-extra'
 import os from 'os'

vscode/extension/tests/python_env.spec.ts

@@ -38,7 +38,10 @@ async function runTest(page: Page, context: CodeServerContext): Promise<void> {
   await openLineageView(page)
 }
 
-async function setupEnvironment(): Promise<[string, PythonEnvironment]> {
+async function setupEnvironment(): Promise<{
+  tempDir: string
+  pythonDetails: PythonEnvironment
+}> {
   const tempDir = await fs.mkdtemp(
     path.join(os.tmpdir(), 'vscode-test-tcloud-'),
   )
@@ -61,15 +64,14 @@ async function setupEnvironment(): Promise<[string, PythonEnvironment]> {
   await fs.writeJson(path.join(tempDir, '.vscode', 'settings.json'), settings, {
     spaces: 2,
   })
-
-  return [tempDir, pythonDetails]
+  return { tempDir, pythonDetails }
 }
 
 test.describe('python environment variable injection on sqlmesh_lsp', () => {
   test('normal setup - error ', async ({ page }, testInfo) => {
     testInfo.setTimeout(120_000)
 
-    const [tempDir, _] = await setupEnvironment()
+    const { tempDir } = await setupEnvironment()
     writeEnvironmentConfig(tempDir)
 
     const context = await startCodeServer({
@@ -87,7 +89,7 @@ test.describe('python environment variable injection on sqlmesh_lsp', () => {
   test('normal setup - set', async ({ page }, testInfo) => {
     testInfo.setTimeout(120_000)
 
-    const [tempDir, _] = await setupEnvironment()
+    const { tempDir } = await setupEnvironment()
     writeEnvironmentConfig(tempDir)
     const env_file = path.join(tempDir, '.env')
     fs.writeFileSync(env_file, 'TEST_VAR=test_value')
@@ -131,7 +133,7 @@ test.describe('tcloud version', () => {
   test('normal setup - error ', async ({ page }, testInfo) => {
     testInfo.setTimeout(120_000)
 
-    const [tempDir, pythonDetails] = await setupEnvironment()
+    const { tempDir, pythonDetails } = await setupEnvironment()
     await setupTcloudProject(tempDir, pythonDetails)
     writeEnvironmentConfig(tempDir)
     const context = await startCodeServer({
@@ -148,7 +150,7 @@ test.describe('tcloud version', () => {
   test('normal setup - set', async ({ page }, testInfo) => {
     testInfo.setTimeout(120_000)
 
-    const [tempDir, pythonDetails] = await setupEnvironment()
+    const { tempDir, pythonDetails } = await setupEnvironment()
     await setupTcloudProject(tempDir, pythonDetails)
     writeEnvironmentConfig(tempDir)
     const env_file = path.join(tempDir, '.env')

vscode/extension/tests/tcloud.spec.ts

@@ -173,8 +173,8 @@ test('signed in and not installed shows installation window', async ({
       .click()
 
     await page.waitForSelector('text=Installing enterprise python package')
-    expect(
-      await page.locator('text=Installing enterprise python package'),
+    await expect(
+      page.locator('text=Installing enterprise python package'),
     ).toHaveCount(2)
 
     await page.waitForSelector('text=Loaded SQLMesh context')

vscode/extension/tests/utils_code_server.ts

@@ -105,15 +105,15 @@ export async function startCodeServer({
       reject(new Error('Code-server failed to start within timeout'))
     }, 30000)
 
-    codeServerProcess.stdout?.on('data', data => {
+    codeServerProcess.stdout?.on('data', (data: Buffer) => {
       output += data.toString()
       if (output.includes('HTTP server listening on')) {
         clearTimeout(timeout)
         resolve()
       }
     })
 
-    codeServerProcess.stderr?.on('data', data => {
+    codeServerProcess.stderr?.on('data', (data: Buffer) => {
       console.error('Code-server stderr:', data.toString())
     })