RSA ClientConnectionContainer Bugfix

Author: Toemsel

Network/ClientConnectionContainer.cs

@@ -91,10 +91,7 @@ public class ClientConnectionContainer : ConnectionContainer, IPacketHandler, ID
         /// <param name="ipAddress">The ip address.</param>
         /// <param name="port">The port.</param>
         internal ClientConnectionContainer(string ipAddress, int port)
-            : base(ipAddress, port)
-        {
-            Initialize();
-        }
+            : base(ipAddress, port) { }
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ClientConnectionContainer"/> class.
@@ -106,13 +103,12 @@ internal ClientConnectionContainer(TcpConnection tcpConnection, UdpConnection ud
         {
             this.tcpConnection = tcpConnection;
             this.udpConnection = udpConnection;
-            Initialize();
         }
 
         /// <summary>
         /// Initializes this instance and starts connecting to the endpoint.
         /// </summary>
-        private void Initialize()
+        internal void Initialize()
         {
             reconnectTimer = new Timer();
             reconnectTimer.Elapsed += TryToConnect;

Network/ConnectionFactory.cs

@@ -316,7 +316,12 @@ public static async Task<Tuple<UdpConnection, ConnectionResult>> CreateSecureUdp
         /// Creates a new instance of a connection container.
         /// </summary>
         /// <returns>ConnectionContainer.</returns>
-        public static ClientConnectionContainer CreateClientConnectionContainer(string ipAddress, int port) => new ClientConnectionContainer(ipAddress, port);
+        public static ClientConnectionContainer CreateClientConnectionContainer(string ipAddress, int port)
+        {
+            var clientConnectionContainer = new ClientConnectionContainer(ipAddress, port);
+            clientConnectionContainer.Initialize();
+            return clientConnectionContainer;
+        }
 
         /// <summary>
         /// Creates a new instance of a secure-connection container. (RSA Encryption)
@@ -325,7 +330,12 @@ public static async Task<Tuple<UdpConnection, ConnectionResult>> CreateSecureUdp
         /// <param name="keySize">The keySize.</param>
         /// </summary>
         /// <returns>ConnectionContainer.</returns>
-        public static ClientConnectionContainer CreateSecureClientConnectionContainer(string ipAddress, int port, string publicKey, string privateKey, int keySize = 2048) => new SecureClientConnectionContainer(ipAddress, port, publicKey, privateKey, keySize);
+        public static ClientConnectionContainer CreateSecureClientConnectionContainer(string ipAddress, int port, string publicKey, string privateKey, int keySize = 2048)
+        {
+            var secureClientConnectionContainer = new SecureClientConnectionContainer(ipAddress, port, publicKey, privateKey, keySize);
+            secureClientConnectionContainer.Initialize();
+            return secureClientConnectionContainer;
+        }
 
         /// <summary>
         /// Creates a new instance of a connection container.
@@ -338,7 +348,10 @@ public static ClientConnectionContainer CreateClientConnectionContainer(TcpConne
         {
             if (tcpConnection == null ||!tcpConnection.IsAlive)
                 throw new ArgumentException("TCP connection must be connected to an endpoint.");
-            return new ClientConnectionContainer(tcpConnection, udpConnection);
+
+            var clientConnectionContainer = new ClientConnectionContainer(tcpConnection, udpConnection);
+            clientConnectionContainer.Initialize();
+            return clientConnectionContainer;
         }
 
         /// <summary>
@@ -355,7 +368,10 @@ public static ClientConnectionContainer CreateSecureClientConnectionContainer(Tc
         {
             if (tcpConnection == null || !tcpConnection.IsAlive)
                 throw new ArgumentException("TCP connection must be connected to an endpoint.");
-            return new SecureClientConnectionContainer(tcpConnection, udpConnection, publicKey, privateKey, keySize);
+            
+            var secureClientConnectionContainer = new SecureClientConnectionContainer(tcpConnection, udpConnection, publicKey, privateKey, keySize);
+            secureClientConnectionContainer.Initialize();
+            return secureClientConnectionContainer;
         }
 
         /// <summary>

Network/Network.csproj

@@ -6,7 +6,7 @@
      <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
      <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
      <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
-     <Version>5.1.0.5</Version>
+     <Version>5.1.0.6</Version>
      <Authors>Thomas Christof</Authors>
      <Company>Indie-Dev</Company>
      <Description>Network library supporting: TCP, UDP, Bluetooth, RSA, events and objects. Fast and simple, with only 48bit overhead per packet. Send and receive packets with async operations.
@@ -29,8 +29,8 @@ Fork me: https://github.com/Toemsel/Network</Description>
      <PackageTags>TCP, UDP, Bluetooth, Network, Events, Async, RSA</PackageTags>
      <PackageReleaseNotes>RSA support for .NET Standard 2.0</PackageReleaseNotes>
      <NeutralLanguage>en-US</NeutralLanguage>
-     <AssemblyVersion>5.1.0.5</AssemblyVersion>
-     <FileVersion>5.1.0.5</FileVersion>
+     <AssemblyVersion>5.1.0.6</AssemblyVersion>
+     <FileVersion>5.1.0.6</FileVersion>
   </PropertyGroup>
   <ItemGroup>
     <Compile Remove="packages\**" />