Skip to content

Conversation

Bobi222
Copy link

@Bobi222 Bobi222 commented Oct 15, 2025

Fixes and closes #1134

@Bobi222 Bobi222 requested a review from a team as a code owner October 15, 2025 17:20
@Zabuzard Zabuzard changed the title new fix without regex Fixes quotation marks in titles on /transfer Oct 16, 2025
@Zabuzard Zabuzard added bug Something isn't working priority: normal labels Oct 16, 2025
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. can u test it please?
maybe temporarily edit the line above to inject a bad title like String title = "\"Hello\""; and then use /transfer in your local test server to verify it works as expected.
You can then send a screenshot here and if its good we can merge it 👍

(btw, you need to learn to improve your PR titles and descriptions a bit. Ive added the bare minimum for you now.)

@Bobi222
Copy link
Author

Bobi222 commented Oct 16, 2025

looks good to me. can u test it please? maybe temporarily edit the line above to inject a bad title like String title = "\"Hello\""; and then use /transfer in your local test server to verify it works as expected. You can then send a screenshot here and if its good we can merge it 👍

(btw, you need to learn to improve your PR titles and descriptions a bit. Ive added the bare minimum for you now.)

Of course. Yea im working on it..

@Bobi222
Copy link
Author

Bobi222 commented Oct 16, 2025

Στιγμιότυπο οθόνης 2025-10-16 121701 Στιγμιότυπο οθόνης 2025-10-16 121650

Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inconsistency in titles generated by GPT

2 participants