feat: Noise IK handshake implementation#3028
Open
iphydf wants to merge 1 commit intoTokTok:masterfrom
Open
Conversation
github-actions
bot
added
the
enhancement
iphydf
force-pushed
the
noise-ik
branch
4 times, most recently
from
cf3e3c1 to
1439c3a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3028 +/- ##
==========================================
+ Coverage 69.36% 69.42% +0.05%
==========================================
Files 184 186 +2
Lines 34156 34859 +703
==========================================
+ Hits 23694 24202 +508
- Misses 10462 10657 +195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iphydf
force-pushed
the
noise-ik
branch
10 times, most recently
from
6a7b96f to
6d448bb
Compare
Green-Sky
reviewed
Mar 4, 2026
toxcore/noise.h
Outdated
| * | ||
| * Verified using Noise_IK_25519_ChaChaPoly_BLAKE2b test vectors. | ||
| * | ||
| * @param output1 First key to compute; must be non-null and first_len <= CRYPTO_NOISE_BLAKE2B_HASH_SIZE. |
Member
There was a problem hiding this comment.
Why are we talking about first_len requirements here.
Change to and of length first_len or drop.
Same with second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #426.
This change is