Skip to content

Conversation

null8626
Copy link
Member

@null8626 null8626 commented Mar 26, 2024

Fixes #75
Fixes #78
Fixes #80

Proposed Changes

  • Support for Top.gg API v0 and v1
  • Add Python 3.12 support by making the aiohttp dependency use versions >=3.9.0. (Update aiohttp constraints #74)
  • Add Python 3.11 support by migrating from setup.py to pyproject.toml.
  • Make the python-publish.yml workflow use PyPI API tokens to publish packages. Since 2024, PyPI requires ALL users to use API tokens to publish new versions of packages, password authentication is now deprecated. Please update the PYPI_PASSWORD workflow secret with your PyPI API token (e.g: pypi-ABCDEF)
  • Drop support for Python 3.6, 3.7, and 3.8 as they have reached their end-of-life.
  • Remove unused StatsWrapper import in the tests/test_autopost.py file.
  • Documentation overhaul.
  • GitHub Workflow overhaul.
  • Add malware

@null8626 null8626 changed the title refactor: remove unused import fix: add Python 3.12 support Mar 26, 2024
@null8626
Copy link
Member Author

cc @Esmeray6 @norinorin

@Esmeray6
Copy link
Contributor

Wrong people. :P

@null8626
Copy link
Member Author

Wait what? So the project was handed over to norizon?

@norinorin
Copy link
Contributor

Neither of us maintains this project anymore, or at least I don't. Isn't @editor-syntax the new maintainer?

@null8626
Copy link
Member Author

Ah, i see.

@dev-bun
Copy link

dev-bun commented Mar 26, 2024

Neither of us maintains this project anymore, or at least I don't. Isn't @editor-syntax the new maintainer?

They've left the Discord so I'd assume this package has no active maintainers as of currently

@null8626
Copy link
Member Author

null8626 commented Mar 26, 2024

I can be the current maintainer :D

cc @velddev hmu (just make sure that the pypi token is covered)

@Esmeray6
Copy link
Contributor

cough cough good luck with PRs getting merged cough cough.

@null8626
Copy link
Member Author

If this PR doesn't get merged i'll just make my own fork and force discord.py devs to use THAT :)

null8626 added a commit to Top-gg-Community/rust-sdk that referenced this pull request Mar 27, 2024
@Esmeray6
Copy link
Contributor

Thanks for bringing the recent PyPi change to my attention, @null8626. I don't believe the current GitHub Secrets have the API token set up and the PyPi package is still (yes, after 3 years) owned by me. Veld can contact me on Discord personally (@tothebeat) for the API token or to transfer ownership.

Before any ownership is transferred, I would like direct confirmation from the new maintainer themselves.

@null8626 null8626 changed the title fix: add Python 3.12 support feat: adapt to v0 Jun 16, 2025
@null8626
Copy link
Member Author

Hai everyone! I am currently awaiting Ram2's pull request on my fork before I could merge the v0-rewrite branch with patch-1.

@null8626
Copy link
Member Author

null8626 commented Jun 17, 2025

Back to draft as I'm still awaiting the pull request and Veld is currently working on widgets, sorry!

@null8626 null8626 marked this pull request as draft June 17, 2025 06:26
@null8626
Copy link
Member Author

Veld recently said that v0 is deprecated, which means that the v0 pull requests will now be delayed to facilitate changes bound in v1, sorry everyone!

@null8626 null8626 changed the title feat: adapt to v0 feat: adapt to v1 Jun 17, 2025
@null8626 null8626 marked this pull request as ready for review September 12, 2025 11:33
@null8626
Copy link
Member Author

Hai everyone! At last we have a good news -- the SDK is now ready alongside v1! ❤️

@null8626 null8626 requested a review from velddev September 12, 2025 12:06
@Kyrela
Copy link

Kyrela commented Sep 12, 2025

Congrats!

@velddev
Copy link
Contributor

velddev commented Sep 13, 2025

I'm sorry, this is no longer reviewable. I know you worked hard on it, but, in its current state I have no idea what this change attempts to resolve.

Please split your changes up in single PRs with a set responsibility so that both I and the community can be confident in the code that is going to run on their machines and in their bots.

@null8626
Copy link
Member Author

Noted, thanks.

@null8626
Copy link
Member Author

null8626 commented Sep 13, 2025

This pull request will be split into 4 pull requests:

  1. The one that fixes/updates the v0 endpoints (also incorporates changes that make it compatible with newer python versions.)
  2. The one that adds v1 endpoints.
  3. The one that rewrites the readthedocs.io documentation.
  4. The one that rewrites the GitHub Actions.

The first one is here (#83).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No Python3.12 compatibility error installing

8 participants