Skip to content

Missing transpose of cell in TorchSimTrajectory.get_atoms() to obey ASE convention #554

@MichaelKetter

Description

@MichaelKetter

When converting an ASE-object to a torch-sim SimState object via io.atoms_to_state() the cell is transposed to follow the TorchSim convention. However, when reading in a TorchSimTrajectory and converting it to an ASE-object via the TorchSimTrajectory.get_atoms() function, the cell is not transposed back to ASE convention. A simple fix would be to modify the associated part in the TorchSimTrajectory.get_atoms()- function from cell=np.ascontiguousarray(arrays["cell"])[0] to cell=np.ascontiguousarray(arrays["cell"])[0].T.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions