Shop products page is added - issue #266#331
Shop products page is added - issue #266#331clownfish1805 wants to merge 5 commits intoTrisha-tech:masterfrom
Conversation
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
Is it necessary to use hardcoded image in base64 format? |
Trisha-tech
left a comment
There was a problem hiding this comment.
Width is too large according to me which hinders the overall image height. @clownfish1805
What you say @Suman373 ?
Yes and the image format reduces the code readability |
|
@Suman373 @Trisha-tech |
Yes. But some images have base64 string in the image source. Could u please make them an image url from unsplash too? |
|
@clownfish1805 pls resolve the conflicts |



Description
Related Issues
Changes
Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.
npm installto install dependencies.npm testto execute the test suite.Screenshots (if applicable)