Skip to content

fix template/parseEnvironment function #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix template/parseEnvironment function #574

wants to merge 2 commits into from

Conversation

@MunifTanjim
Copy link

fixes #573

@mgerdts
Copy link
Contributor

mgerdts commented May 3, 2019

Thanks for this PR. The code looks good, but we could use a test in config/template/template_test.go.

@mgerdts mgerdts self-requested a review May 3, 2019 14:49
@MunifTanjim
Copy link
Author

@mgerdts added a test case

@MunifTanjim
Copy link
Author

@mgerdts any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgerdts mgerdts Awaiting requested review from mgerdts

1 more reviewer

@geek geek geek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error parsing environment variable in config template

3 participants

@MunifTanjim @mgerdts @geek