Fix build failure; a variety of cleanup #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the build failing. For reference, the warnings fixed are: * https://github.com/koalaman/shellcheck/wiki/SC2181 * https://github.com/koalaman/shellcheck/wiki/SC1117
Lots of small cleanup around here. Added '?' to the getopts loop list, escaped '?' appropriately, and no longer exit with error when the user requests the help text to print.
The ':' in getops already ensures that these flags are passed arguments. This checks the argument vars (which will be set) to infer whether these flags were declared.
A few notes: * [-a ] is deprecated in favor of the more common [ -e ] * Bash supports Substring Extraction, so even less of a need to invoke `cut` and a subshell to get one character. * use shell's pattern matching rather than invoking awk; use file's -b option for convenience.
|
Seems the new build failure is unrelated to my patches, and is likely due to the interaction of
|
Travis's stuff is... odd. They white list a bajillion external repos, but not Canonical's official backports for Trusty. One of many unfortunate oddities on the service. Because it's a new repo, I have to use "require: sudo", which gets us on the VM infra rather than the container infra. It's worth it though, to actually get this working.
|
Build finally passes. shellcheck is now installed from Trusty backports rather than Debian sid. |
|
ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a variety of cleanup and unifying of some of the checks across the scripts, since each script did things a bit differently.
There's a lot of small errors left in these scripts --- some dangerous (unquoted
rm, etc). But I didn't want to send a big stack of changes if they weren't wanted.These patches are pretty independent, so feel free to cherry-pick as you see fit. If you're interested in more cleanup, let me know and I'll be happy to spend more time on it.
---Alex