Skip to content

Conversation

SamWhited
Copy link

@SamWhited SamWhited commented Jul 20, 2018

Right now if you attempt to remove resources created with this module terraform will fail because the triton provider from the module will be removed, and therefore doesn't exist to remove any of the resources created with it. Best practice is to put the provider only in your root module and pass it into any modules you use. This can be done explicitly or implicitly. To keep this change minimal I just moved it to the example as an implicit use of the same provider.

For more information on best practices when creating providers see: https://www.terraform.io/docs/modules/usage.html#providers-within-modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant