Skip to content

Conversation

@Srabasti
Copy link

…sers

Adding fixes to avoid setup errors for Windows users #372

…sers

Adding fixes to avoid setup errors for Windows users Trusted-AI#372

Signed-off-by: Srabasti Banerjee <srabasti_b@ymail.com>
Copy link

@aviiciii aviiciii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@yehee yehee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just swinging by to give initial pass on the commit, I'll leave project owners to review :)

README.md Outdated
pip install --editable '.[all]'
```

###For Windows machine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
###For Windows machine
### For Windows machine

README.md Outdated
pip install --editable '.[all]'
```

###For Windows machine

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since this is conda installation instructions, lets add this to the conda section: https://github.com/Trusted-AI/AIF360#conda

mnagired and others added 2 commits September 27, 2023 12:33
Co-authored-by: Gowri Addepalli <gauriaddepalli@gmail.com>
Signed-off-by: Manish Nagireddy <65432909+mnagired@users.noreply.github.com>
Co-authored-by: Gowri Addepalli <gauriaddepalli@gmail.com>
Co-authored-by: Alice <aliceykim0828@gmail.com>
Signed-off-by: Manish Nagireddy <65432909+mnagired@users.noreply.github.com>
Copy link
Collaborator

@mnagired mnagired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for doing this!

Copy link
Author

@Srabasti Srabasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants