added feedback functionalities

Author: AnkitTukatek

backend/onyx/server/query_and_chat/chat_backend.py

@@ -8,7 +8,7 @@
 from datetime import timedelta
 from uuid import UUID
 
-from fastapi import APIRouter
+from fastapi import APIRouter,Path
 from fastapi import Depends
 from fastapi import HTTPException
 from fastapi import Query
@@ -100,7 +100,14 @@
 from shared_configs.contextvars import get_current_tenant_id
 from sqlalchemy.orm import Session, joinedload
 from sqlalchemy import desc
-
+from typing import Optional
+from datetime import datetime
+from fastapi import Query
+from sqlalchemy.exc import SQLAlchemyError
+from io import StringIO
+import csv
+from sqlalchemy import cast, Date, or_
+from fastapi import Query
 RECENT_DOCS_FOLDER_ID = -1
 
 logger = setup_logger()
@@ -196,52 +203,191 @@ def update_chat_session_model(
     db_session.add(chat_session)
     db_session.commit()
 
+# @router.get("/get-user-feedback")
+# def get_user_feedback(
+#     skip: int = Query(0, ge=0, description="Number of records to skip for pagination"),
+#     limit: int = Query(50, ge=1, le=100, description="Number of records to return"),
+#     user: User = Depends(current_user),
+#     db_session: Session = Depends(get_session),
+# ):
+#     """
+#     Get paginated chat feedbacks for the logged-in user.
+#     Works by joining ChatMessageFeedback -> ChatMessage -> ChatSession
+#     and filtering by ChatSession.user_id = current user.
+#     """
+
+#     # Build query using relationships instead of raw join conditions
+#     base_query = (
+#         db_session.query(ChatMessageFeedback)
+#         .join(ChatMessage, ChatMessage.id == ChatMessageFeedback.chat_message_id)
+#         .join(ChatSession, ChatSession.id == ChatMessage.chat_session_id)
+#         .filter(ChatSession.user_id == user.id)  # strictly this user's sessions
+#         .order_by(ChatMessageFeedback.feedback_timestamp.desc())
+#     )
+
+#     total_count = base_query.count()
+#     feedback_rows = base_query.offset(skip).limit(limit).all()
+
+#     return {
+#         "total": total_count,
+#         "skip": skip,
+#         "limit": limit,
+#         "feedbacks": [
+#             {
+#                 "id": fb.id,
+#                 "chat_message_id": fb.chat_message_id,
+#                 "is_positive": fb.is_positive,
+#                 "feedback_text": fb.feedback_text,
+#                 "required_followup": fb.required_followup,
+#                 "predefined_feedback": fb.predefined_feedback,
+#                 "feedback_timestamp": fb.feedback_timestamp,
+#             }
+#             for fb in feedback_rows
+#         ],
+#     }
+
 @router.get("/get-user-feedback")
 def get_user_feedback(
-    skip: int = Query(0, ge=0, description="Number of records to skip for pagination"),
-    limit: int = Query(50, ge=1, le=100, description="Number of records to return"),
+    skip: int = Query(0, ge=0, description="Number of records to skip for pagination. Must be >= 0."),
+    limit: int = Query(50, ge=1, le=100, description="Number of records to return. Must be between 1 and 100."),
+    start_date: Optional[datetime] = Query(None, description="Start date filter (YYYY-MM-DD), time ignored."),
+    end_date: Optional[datetime] = Query(None, description="End date filter (YYYY-MM-DD), time ignored."),
+    search: Optional[str] = Query(None, description="Search feedback by ID or feedback text."),
+    download: bool = Query(False, description="Download the current page's feedback as CSV if true."),
     user: User = Depends(current_user),
     db_session: Session = Depends(get_session),
 ):
-    """
-    Get paginated chat feedbacks for the logged-in user.
-    Works by joining ChatMessageFeedback -> ChatMessage -> ChatSession
-    and filtering by ChatSession.user_id = current user.
-    """
+    if start_date and end_date and start_date.date() > end_date.date():
+        raise HTTPException(
+            status_code=400,
+            detail="Invalid date range: start_date must be less than or equal to end_date."
+        )
+    
+    try:
+        base_query = (
+            db_session.query(ChatMessageFeedback, ChatSession)
+            .join(ChatMessage, ChatMessage.id == ChatMessageFeedback.chat_message_id)
+            .join(ChatSession, ChatSession.id == ChatMessage.chat_session_id)
+            .filter(ChatSession.user_id == user.id)
+        )
+        
+        if start_date:
+            base_query = base_query.filter(
+                cast(ChatMessageFeedback.feedback_timestamp, Date) >= start_date.date()
+            )
+        if end_date:
+            base_query = base_query.filter(
+                cast(ChatMessageFeedback.feedback_timestamp, Date) <= end_date.date()
+            )
+        
+        if search:
+            if search.isdigit():
+                base_query = base_query.filter(
+                    or_(
+                        ChatMessageFeedback.id == int(search),
+                        ChatMessageFeedback.feedback_text.ilike(f"%{search}%")
+                    )
+                )
+            else:
+                base_query = base_query.filter(ChatMessageFeedback.feedback_text.ilike(f"%{search}%"))
+        
+        base_query = base_query.order_by(ChatMessageFeedback.feedback_timestamp.desc())
+        
+        total_count = base_query.count()
+
+        if download:
+            feedback_rows = base_query.all()
+        else:
+            feedback_rows = base_query.offset(skip).limit(limit).all()
+        
+        if download:
+            from io import StringIO
+            import csv
+            from fastapi.responses import StreamingResponse
+            
+            output = StringIO()
+            writer = csv.writer(output)
+            writer.writerow([
+                "feedback_text", "is_positive", "feedback_timestamp",
+                "chat_session_id", "chat_session_name"
+            ])
+            for fb, chat in feedback_rows:
+                writer.writerow([
+                    fb.feedback_text, fb.is_positive, fb.feedback_timestamp,
+                    chat.id, chat.description
+                ])
+            output.seek(0)
+            return StreamingResponse(
+                output,
+                media_type="text/csv",
+                headers={"Content-Disposition": f"attachment; filename=chat_feedback_{user.id}_all.csv"}
+            )
+        
+        return {
+            "total": total_count,
+            "skip": skip,
+            "limit": limit,
+            "feedbacks": [
+                {
+                    "id": fb.id,
+                    "chat_message_id": fb.chat_message_id,
+                    "is_positive": fb.is_positive,
+                    "feedback_text": fb.feedback_text,
+                    "required_followup": fb.required_followup,
+                    "predefined_feedback": fb.predefined_feedback,
+                    "feedback_timestamp": fb.feedback_timestamp,
+                    "chat_session": {
+                        "id": chat.id,
+                        "name": chat.description,
+                        "persona_id": chat.persona_id,
+                        "time_created": chat.time_created.isoformat(),
+                        "time_updated": chat.time_updated.isoformat(),
+                        "shared_status": chat.shared_status,
+                        "folder_id": chat.folder_id,
+                        "current_alternate_model": chat.current_alternate_model,
+                        "current_temperature_override": chat.temperature_override,
+                    }
+                }
+                for fb, chat in feedback_rows
+            ],
+        }
+    
+    except ValueError as ve:
+        raise HTTPException(status_code=422, detail=f"Value error: {str(ve)}")
+    except SQLAlchemyError:
+        raise HTTPException(status_code=500, detail="Database error occurred. Please try again later.")
+    except Exception as e:
+        raise HTTPException(status_code=500, detail=f"An unexpected error occurred: {str(e)}")
 
-    # Build query using relationships instead of raw join conditions
-    base_query = (
+@router.delete("/delete-feedback/{feedback_id}")
+def delete_feedback(
+    feedback_id: int = Path(..., description="ID of the feedback to delete"),
+    user: User = Depends(current_user),
+    db_session: Session = Depends(get_session),
+):
+    # Find feedback by ID and ensure it belongs to current user
+    feedback = (
         db_session.query(ChatMessageFeedback)
         .join(ChatMessage, ChatMessage.id == ChatMessageFeedback.chat_message_id)
         .join(ChatSession, ChatSession.id == ChatMessage.chat_session_id)
-        .filter(ChatSession.user_id == user.id)  # strictly this user's sessions
-        .order_by(ChatMessageFeedback.feedback_timestamp.desc())
+        .filter(ChatMessageFeedback.id == feedback_id)
+        .filter(ChatSession.user_id == user.id)
+        .first()
     )
 
-    total_count = base_query.count()
-    feedback_rows = base_query.offset(skip).limit(limit).all()
+    if not feedback:
+        raise HTTPException(status_code=404, detail="Feedback not found or you do not have permission to delete it.")
+
+    # Delete feedback
+    db_session.delete(feedback)
+    db_session.commit()
 
     return {
-        "total": total_count,
-        "skip": skip,
-        "limit": limit,
-        "feedbacks": [
-            {
-                "id": fb.id,
-                "chat_message_id": fb.chat_message_id,
-                "is_positive": fb.is_positive,
-                "feedback_text": fb.feedback_text,
-                "required_followup": fb.required_followup,
-                "predefined_feedback": fb.predefined_feedback,
-                "feedback_timestamp": fb.feedback_timestamp,
-            }
-            for fb in feedback_rows
-        ],
+        "message": "Successfully deleted",
+        "status": "Success"
     }
 
 
-
-
 @router.get("/get-chat-session/{session_id}")
 def get_chat_session(
     session_id: UUID,